roachtest: activerecord failed #94042
Assignees
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-roachtest
O-robot
Originated from a bot.
release-blocker
Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
Comments
cockroach-teamcity
added
branch-master
|
From the test log: From looking at the PRs that were merged in the last 24 hours, I think this one might be relevant: #93858. |
|
The generated code for the ... So, the first member in the group, |
msirek
pushed a commit
to msirek/cockroach
that referenced
this issue
Dec 21, 2022
Fixes cockroachdb#94042 This fixes a slightly confusing feature of optgen where an alias in a match rule is assigned to the first expression in the group, and may be of a different expression type than the allowed Ops in the match rule. Example: ``` [GenerateStreamingGroupByLimitOrderingHint, Explore] (Limit $aggregation:(GroupBy | DistinctOn ``` Given this match rule, it looks like `$aggregation` can only be a GroupBy or DistinctOn expression. But in cockroachdb#94042, it is sometimes a Select expression. The variable is later used to generate a new expression with the assumption it is one of the allowed Op types, causing a panic. This is fixed by updating the optgen rule gen code to keep the alias up-to-date with the current memo group member being examined in the match rule, as it cycles through all members in the group. Release note: None
craig bot
pushed a commit
that referenced
this issue
Dec 22, 2022
94112: main: update optgen Op alias to match current memo group member r=DrewKimball a=msirek Fixes #94042 This fixes a slightly confusing feature of optgen where an alias in a match rule is assigned to the first expression in the group, and may be of a different expression type than the allowed Ops in the match rule. Example: ``` [GenerateStreamingGroupByLimitOrderingHint, Explore] (Limit $aggregation:(GroupBy | DistinctOn ``` Given this match rule snippet, it looks like `$aggregation` can only be a GroupBy or DistinctOn expression. But in #94042, it is sometimes a Select expression. The variable is later used to generate a new expression with the assumption it is one of the allowed Op types, causing a panic. This is fixed by updating the optgen rule gen code to keep the alias up-to-date with the current memo group member being examined in the match rule, as it cycles through all members in the group. Release note: None Co-authored-by: Mark Sirek <[email protected]>
msirek
pushed a commit
to msirek/cockroach
that referenced
this issue
Dec 29, 2022
Fixes cockroachdb#94042 This fixes a slightly confusing feature of optgen where an alias in a match rule is assigned to the first expression in the group, and may be of a different expression type than the allowed Ops in the match rule. Example: ``` [GenerateStreamingGroupByLimitOrderingHint, Explore] (Limit $aggregation:(GroupBy | DistinctOn ``` Given this match rule, it looks like `$aggregation` can only be a GroupBy or DistinctOn expression. But in cockroachdb#94042, it is sometimes a Select expression. The variable is later used to generate a new expression with the assumption it is one of the allowed Op types, causing a panic. This is fixed by updating the optgen rule gen code to keep the alias up-to-date with the current memo group member being examined in the match rule, as it cycles through all members in the group. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
roachtest.activerecord failed with artifacts on master @ 10266a323f94c3cf397d5de590e512d987e63e22:
Parameters:
ROACHTEST_cloud=gce,ROACHTEST_cpu=4,ROACHTEST_encrypted=false,ROACHTEST_fs=ext4,ROACHTEST_localSSD=true,ROACHTEST_ssd=0Help
See: roachtest README
See: How To Investigate (internal)
Same failure on other branches
This test on roachdash | Improve this report!
Jira issue: CRDB-22660
The text was updated successfully, but these errors were encountered: