Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the workload Insights default to statements for 22.2 #92931

Closed
kevin-v-ngo opened this issue Dec 2, 2022 · 0 comments
Closed

Change the workload Insights default to statements for 22.2 #92931

kevin-v-ngo opened this issue Dec 2, 2022 · 0 comments
Assignees
@maryliag
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@kevin-v-ngo
Copy link

kevin-v-ngo commented Dec 2, 2022 •
edited by cockroach-jira-scripts
Loading

In 22.2, we primarily have insights surfaced at the statement level. We should make this the default so it's more discoverable.

In 23.1, once we have transaction-level insights, we can revert the behavior as the transaction is typically the entry point for end users when debugging a performance issue.

Jira issue: CRDB-22057
@kevin-v-ngo kevin-v-ngo added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Dec 2, 2022
@maryliag maryliag self-assigned this Dec 2, 2022
maryliag added a commit to maryliag/cockroach that referenced this issue Dec 2, 2022
@maryliag
ui: change selection order of insights
c35f821 
Previously, the Workload Insights view were first
Transaction and then Statements. Since 22.2 has more
information on a Statement level, this commit changes
the order of views, so Stament is first and Transactions
is second.

Fixes cockroachdb#92931

Release note (ui change): Switch order of Transaction
and Statement views on Workload Insights.
maryliag added a commit to maryliag/cockroach that referenced this issue Dec 2, 2022
@maryliag
ui: change selection order of workload insights
f0bc602 
Previously, the Workload Insights view were first
Transaction and then Statements. Since 22.2 has more information on a
Statement level, this commit changes the order of views, so Statement is first
and Transactions is second.

Fixes cockroachdb#92931

Release note (ui change): Switch order of Transaction and Statement
views on Workload Insights.
@maryliag maryliag mentioned this issue Dec 2, 2022
Merged
@maryliag maryliag closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maryliag @kevin-v-ngo