Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test: TestTenantLogic_zero failed #92108

Closed
cockroach-teamcity opened this issue Nov 18, 2022 · 1 comment · Fixed by #92166
Closed

pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test: TestTenantLogic_zero failed #92108

cockroach-teamcity opened this issue Nov 18, 2022 · 1 comment · Fixed by #92166
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Nov 18, 2022 •
edited by cockroach-jira-scripts
Loading

pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test.TestTenantLogic_zero failed with artifacts on master @ a035d2e6e7ea57b30115ecc8ee1a5d553a9e3412:

Fatal error:

panic: test timed out after 59m55s

Stack:

goroutine 7178636 [running]:
testing.(*M).startAlarm.func1()
	GOROOT/src/testing/testing.go:2036 +0x8e
created by time.goFunc
	GOROOT/src/time/sleep.go:176 +0x32
Log preceding fatal error 

=== RUN   TestTenantLogic_zero
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/47424cbdfa0dc4481b838b4a69ffa32f/logTestTenantLogic_zero2775791373
    test_log_scope.go:79: use -show-logs to present logs inline

Parameters: TAGS=bazel,gss

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-21577
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Nov 18, 2022
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Nov 18, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Nov 18, 2022
@rytaft
Copy link
Collaborator

rytaft commented Nov 18, 2022

Looks like the TestTenantLogic tests just took a long time to run, zero was what happened to be running when the timer ran out.

@rytaft rytaft mentioned this issue Nov 18, 2022
Closed
@rytaft rytaft mentioned this issue Nov 18, 2022
Merged
craig bot pushed a commit that referenced this issue Nov 18, 2022
@andreimatei @renatolabs @rytaft
Merge #92140 #92147 #92153 #92166
e9f217f 
92140: roachtest: geo distributed roachtests which specify a number of nodes… r=smg260 a=smg260

… strictly less

than the default number of gcloud zones (currently 9) result in a gcloud syntax error for omission of instance name. This happens because we loop through `len(zones)` instead of `len(nodes)`

Resolves: #92150
Release note: none
Epic: none

92147: testcluster: don't swallow node start error r=andreimatei a=andreimatei

The buggy code path had the structure:
```
func bug() {
  var err error
  if err := foo(); err != nil {
    if cond {
      goexit
    }
  }
  return err
}
```
This inadvertently swallws foo()'s error when `!cond`, because foo's error has a smaller scope than the error that ends up being returned.

Release note: None
Epic: None

92153: roachtest: wait for upgrade to complete using retry loop in tpcc r=srosenberg a=renatolabs

Previously, the `tpcc/mixed-headroom` roachtests would reset the `preserve_downgrade_option` setting and then wait for the upgrade to finish by running a `SET CLUSTER SETTING version = '...'` statement. However, that is not reliable as it's possible for that statement to return an error if the resetting of the `preserve_downgrade_option` has not been propagated yet (see #87201).

To avoid this type of flake (which has been observed in manual runs), we use a retry loop waiting for the cluster version to converge, as is done by the majority of upgrade-related roachtests.

Epic: None.
Release note: None

92166: cmd: increase logictestccl stress timeout to 2h r=rytaft a=rytaft

The default timeout of 1h is not enough. Increase it to 2h to match the regular logictests.

Fixes #92108

Release note: None

Co-authored-by: Miral Gadani <[email protected]>
Co-authored-by: Andrei Matei <[email protected]>
Co-authored-by: Renato Costa <[email protected]>
Co-authored-by: Rebecca Taft <[email protected]>
@craig craig bot closed this as completed in 93443e7 Nov 18, 2022
blathers-crl bot pushed a commit that referenced this issue Nov 18, 2022
@rytaft
cmd: increase logictestccl stress timeout to 2h
9112d7a 
The default timeout of 1h is not enough. Increase it to 2h to match
the regular logictests.

Fixes #92108

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Nov 18, 2022
Merged
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

cmd: increase logictestccl stress timeout to 2h rytaft/cockroach
2 participants
@rytaft @cockroach-teamcity