Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: tenantID field unnused in api_v2 code #91829

Closed
knz opened this issue Nov 14, 2022 · 3 comments · Fixed by #91840
Closed

server: tenantID field unnused in api_v2 code #91829

knz opened this issue Nov 14, 2022 · 3 comments · Fixed by #91840
Assignees
@dhartunian
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Nov 14, 2022 •
edited by cockroach-jira-scripts
Loading

Found in CI linter: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_UnitTests/7502335?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true

------- Stdout: -------
=== RUN   TestLint/TestStaticCheck
    lint_test.go:1751:
        pkg/server/api_v2.go:103:2: field tenantID is unused (U1000)
    --- FAIL: TestLint/TestStaticCheck (955.08s)

Jira issue: CRDB-21447
@knz knz added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Nov 14, 2022
@stevendanna
Copy link
Collaborator

Interesting question here is why doesn't the bazel build hit this as well?

@knz
Copy link
Contributor Author

knz commented Nov 14, 2022

Interesting question here is why doesn't the bazel build hit this as well?

good q. @renatolabs @srosenberg thoughts?

@renatolabs
Copy link
Contributor

renatolabs commented Nov 14, 2022 •
edited
Loading

Interesting question here is why doesn't the bazel build hit this as well?

good q. @renatolabs @srosenberg thoughts?

I believe @rickystewart is better equipped to answer this one. I know that this was a documented issue (#76933), but I would have expected the unused lint (#83665) to catch instances like this.

@dhartunian dhartunian mentioned this issue Nov 14, 2022
Merged
craig bot pushed a commit that referenced this issue Nov 14, 2022
@dhartunian @knz
Merge #91840 #91857
bc06ae6 
91840: server: remove unused apiv2 server field r=knz a=dhartunian

Epic: None
Resolves: #91829
Release note: None

91857: skip flaky tests r=andrewbaptist a=knz

Informs #91856
Informs #91858

Co-authored-by: David Hartunian <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
@craig craig bot closed this as completed in 460fea4 Nov 14, 2022
dhartunian added a commit to dhartunian/cockroach that referenced this issue Nov 16, 2022
@dhartunian
server: remove unused apiv2 server field
37749d9 
Epic: None
Resolves: cockroachdb#91829
Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhartunian dhartunian

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: remove unused apiv2 server field dhartunian/cockroach
4 participants
@knz @stevendanna @dhartunian @renatolabs