backupccl: checkMissingIntroducedSpans should use the backupCodec #90475
Assignees
Labels
A-disaster-recovery
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-disaster-recovery
Comments
msbutler
added
C-bug
|
Hi @msbutler, please add branch-* labels to identify which branch(es) this release-blocker affects. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
cc @cockroachdb/disaster-recovery |
msbutler
added a commit
to msbutler/cockroach
that referenced
this issue
Oct 21, 2022
…nifest Informs cockroachdb#90475, cockroachdb#90474 Release note (bug fix): previously, during restore planning, the restoring cluster's codec was accidentally used to reason about spans in the backup manifest. When a backup was restored by a different tenant, two bugs described in cockroachdb#90475, cockroachdb#90474 could manifest. This patch fixes these bugs.
msbutler
changed the title
msbutler
changed the title
craig bot
pushed a commit
that referenced
this issue
Oct 23, 2022
90477: backupccl: use the backup codec when inspecting spans in the backupManifest r=stevendanna a=msbutler Informs #90475, #90474 Release note (bug fix): previously, during restore planning, the restoring cluster's codec was accidentally used to reason about spans in the backup manifest. When a backup was restored by a different tenant, two bugs described in #90475, #90474 could manifest. This patch fixes these bugs. Co-authored-by: Michael Butler <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this issue
Oct 23, 2022
…nifest Informs #90475, #90474 Release note (bug fix): previously, during restore planning, the restoring cluster's codec was accidentally used to reason about spans in the backup manifest. When a backup was restored by a different tenant, two bugs described in #90475, #90474 could manifest. This patch fixes these bugs.
blathers-crl bot
pushed a commit
that referenced
this issue
Oct 23, 2022
…nifest Informs #90475, #90474 Release note (bug fix): previously, during restore planning, the restoring cluster's codec was accidentally used to reason about spans in the backup manifest. When a backup was restored by a different tenant, two bugs described in #90475, #90474 could manifest. This patch fixes these bugs.
|
removing ga blocker, as SRE would only get affected by this, in theory (though they probably don't even do this). |
msbutler
added a commit
to msbutler/cockroach
that referenced
this issue
Oct 24, 2022
…nifest Informs cockroachdb#90475, cockroachdb#90474 Previously, during restore planning, the restoring cluster's codec was accidentally used to reason about spans in the backup manifest. When a backup was restored by a different tenant, two bugs described in cockroachdb#90475, cockroachdb#90474 could manifest. This patch fixes these bugs. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#89981 introduced a check in restore to ensure that a backup chain appropriately introduces spans from previously offline table.s Currently on the restore side, these check uses the restoring cluster's codec, which may not be the same as the backup's codec in a multi tenant cluster. Thus, if the backup and restore tenant prefixes are different, and the backup chain contains an introduced span, this check will cause the restore to spuriously fail.
Jira issue: CRDB-20788
The text was updated successfully, but these errors were encountered: