Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: Remove deprecated PTS code #89450

Closed
miretskiy opened this issue Oct 5, 2022 · 1 comment · Fixed by #89975
Closed

cdc: Remove deprecated PTS code #89450

miretskiy opened this issue Oct 5, 2022 · 1 comment · Fixed by #89975
Assignees
@samiskin
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc

Comments

@miretskiy
Copy link
Contributor

miretskiy commented Oct 5, 2022 •
edited by exalate-issue-sync bot
Loading

With the push to lower default TTL down to hours (instead of 25 hours),
we need to deprecate and remove old PTS code and default "active PTS" to always
on.

Jira issue: CRDB-20257

Epic CRDB-25042
@miretskiy miretskiy added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture T-cdc labels Oct 5, 2022
@blathers-crl
Copy link

blathers-crl bot commented Oct 5, 2022

cc @cockroachdb/cdc

@miretskiy miretskiy mentioned this issue Oct 5, 2022
Closed
@samiskin samiskin mentioned this issue Oct 14, 2022
Merged
craig bot pushed a commit that referenced this issue Nov 7, 2022
@samiskin
Merge #89975
d9abb80 
89975: changefeedccl: cleanup deprecated pts handling r=samiskin a=samiskin

Resolves #89450

Going forward we no longer want customers to be able to turn off active protected timestamps, as we always want to remain resilient to low ttl tables.

Release note (enterprise change):
The changefeed.active_protected_timestamps.enabled cluster setting has been removed and is always treated as if it was true.

Co-authored-by: Shiranka Miskin <[email protected]>
@craig craig bot closed this as completed in 9af72fb Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samiskin samiskin

Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changefeedccl: cleanup deprecated pts handling samiskin/cockroach
2 participants
@samiskin @miretskiy