Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

costfuzz: use of partitions requires an enterprise license #88710

Closed
mgartner opened this issue Sep 26, 2022 · 1 comment · Fixed by #88716
Closed

costfuzz: use of partitions requires an enterprise license #88710

mgartner opened this issue Sep 26, 2022 · 1 comment · Fixed by #88716
Assignees
@renatolabs
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team

Comments

@mgartner
Copy link
Collaborator

mgartner commented Sep 26, 2022 •
edited by cockroach-jira-scripts
Loading

Cosstfuzz can fail with the message:

test artifacts and logs in: /artifacts/costfuzz/run_1
	query_comparison_util.go:147,query_comparison_util.go:66,costfuzz.go:41,test_runner.go:928: pq: use of partitions requires an enterprise license. see https://cockroachlabs.com/pricing?cluster=3f7d2641-1abc-41e9-89ad-45ba2912ab3f for details on how to enable enterprise features

We should eliminate this flake.

Jira issue: CRDB-19906
@mgartner mgartner added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Sep 26, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Sep 26, 2022
@mgartner mgartner mentioned this issue Sep 26, 2022
Closed
@mgartner
Copy link
Collaborator Author

This should be fixed by #88716.

@yuzefovich yuzefovich mentioned this issue Sep 26, 2022
Merged
craig bot pushed a commit that referenced this issue Sep 26, 2022
@aliher1911 @ZhouXing19
@ajwerner @renatolabs
Merge #88252 #88295 #88670 #88716
c432bd7 
88252: storage: add gc benchmarks with multiple range tombstones r=erikgrinaker a=aliher1911

Previously we only had tests that verify GC performance with no range tombstones or with a single range tombstone under all the data. This commit extends the benchmark to have many tombstones interleaving data at different keys.

Release note: None

Fixes #87417

88295: sql: add assertion for txn passed to internal executor r=ajwerner a=ZhouXing19

If an internal executor is created with a txn binding to it, it should not be used to execute a statement with a nil txn.

Release note: None

88670: schemachanger/rel: fix race due to failure to clone constraint slots r=ajwerner a=ajwerner

The fundamental race here is that while the slots themselves were being copied by value, the "any" clauses which are a slice were not. The second bug here is that the "inline" values were not being properly reset. That bug could lead to problems when the query was run again in the context of a different element set. We need to reset those inline values too.

Fixes #88628

Release note: None

88716: roachprod: set default cluster settings when starting r=yuzefovich,srosenberg,smg260 a=renatolabs

In #88514, the cluster start logic was refactored to reuse the same code across `init` and `start`, fixing a bug in the former. However, the refactoring overlooked the fact that we previously always set the default cluster settings when there's more than one node in the cluster.

This fixes that by setting the default cluster settings in that case; one particularly important cluster setting is the license key, necessary for some roachtests.

Fixes #88660
Fixes #88665
Fixes #88666
Fixes #88710.

Release note: None

Co-authored-by: Oleg Afanasyev <[email protected]>
Co-authored-by: Jane Xing <[email protected]>
Co-authored-by: Andrew Werner <[email protected]>
Co-authored-by: Renato Costa <[email protected]>
@craig craig bot closed this as completed in ed443e1 Sep 26, 2022
@craig craig bot closed this as completed in #88716 Sep 26, 2022
smg260 pushed a commit to smg260/cockroach that referenced this issue Jan 18, 2023
@renatolabs
roachprod: set default cluster settings when starting
0e614a5 
In cockroachdb#88514, the cluster start logic was refactored to reuse the same
code across `init` and `start`, fixing a bug in the former. However,
the refactoring overlooked the fact that we previously always set the
default cluster settings when there's more than one node in the
cluster.

This fixes that by setting the default cluster settings in that case;
one particularly important cluster setting is the license key,
necessary for some roachtests.

Fixes cockroachdb#88660.
Fixes cockroachdb#88665.
Fixes cockroachdb#88666.
Fixes cockroachdb#88710.

Release note: None
smg260 pushed a commit to smg260/cockroach that referenced this issue Jan 18, 2023
@renatolabs
roachprod: set default cluster settings when starting
9c0b17d 
In cockroachdb#88514, the cluster start logic was refactored to reuse the same
code across `init` and `start`, fixing a bug in the former. However,
the refactoring overlooked the fact that we previously always set the
default cluster settings when there's more than one node in the
cluster.

This fixes that by setting the default cluster settings in that case;
one particularly important cluster setting is the license key,
necessary for some roachtests.

Fixes cockroachdb#88660.
Fixes cockroachdb#88665.
Fixes cockroachdb#88666.
Fixes cockroachdb#88710.

Release note: None
smg260 pushed a commit to smg260/cockroach that referenced this issue Mar 7, 2023
@renatolabs
roachprod: set default cluster settings when starting
3765da1 
In cockroachdb#88514, the cluster start logic was refactored to reuse the same
code across `init` and `start`, fixing a bug in the former. However,
the refactoring overlooked the fact that we previously always set the
default cluster settings when there's more than one node in the
cluster.

This fixes that by setting the default cluster settings in that case;
one particularly important cluster setting is the license key,
necessary for some roachtests.

Fixes cockroachdb#88660.
Fixes cockroachdb#88665.
Fixes cockroachdb#88666.
Fixes cockroachdb#88710.

Release note: None
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renatolabs renatolabs

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachprod: set default cluster settings when starting renatolabs/cockroach
2 participants
@mgartner @renatolabs