Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tenant: flake in TestTenantLogic_enums/drop_not_null #86215

Closed
cucaroach opened this issue Aug 16, 2022 · 0 comments · Fixed by #86222
Closed

tenant: flake in TestTenantLogic_enums/drop_not_null #86215

cucaroach opened this issue Aug 16, 2022 · 0 comments · Fixed by #86222
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cucaroach
Copy link
Contributor

cucaroach commented Aug 16, 2022 •
edited by cockroach-jira-scripts
Loading

Seen in CI here: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_BazelEssentialCi/6104407?showRootCauses=true&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildDeploymentsSection=true&expandBuildTestsSection=true

=== RUN   TestTenantLogic_enums/drop_not_null
    logic.go:2854:
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/4740/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test_/3node-tenant_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/enums:1225:
        expected success, but found
        (40001) restart transaction: TransactionRetryWithProtoRefreshError: TransactionAbortedError(ABORT_REASON_NEW_LEASE_PREVENTS_TXN): "sql txn" meta={id=1332a4ec key=/Tenant/10/Table/24/1/2/203/2 pri=0.02693599 epo=0 ts=1660594801.062713626,1 min=1660594801.010895257,0 seq=33} lock=true stat=PENDING rts=1660594801.062713626,1 wto=false gul=1660594801.510895257,0
    logic.go:1868:
         pq: restart transaction: TransactionRetryWithProtoRefreshError: TransactionAbortedError(ABORT_REASON_NEW_LEASE_PREVENTS_TXN): "sql txn" meta={id=1332a4ec key=/Tenant/10/Table/24/1/2/203/2 pri=0.02693599 epo=0 ts=1660594801.062713626,1 min=1660594801.010895257,0 seq=33} lock=true stat=PENDING rts=1660594801.062713626,1 wto=false gul=1660594801.510895257,0
[20:20:01] --- done: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/4740/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test_/3node-tenant_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/enums with config 3node-tenant: 216 tests, 2 failures
[20:20:12] --- total progress: 216 statements

Jira issue: CRDB-18637
@cucaroach cucaroach added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Aug 16, 2022
@cucaroach cucaroach mentioned this issue Aug 16, 2022
Merged
@ajwerner ajwerner mentioned this issue Aug 16, 2022
Merged
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Aug 16, 2022
craig bot pushed a commit that referenced this issue Aug 16, 2022
@chengxiong-ruan @adityamaru
@rafiss @yuzefovich @irfansharif @jbowens @ajwerner
Merge #85900 #85964 #86156 #86179 #86185 #86219 #86222 #86231
7c38417 
85900: sql: implement `REPLACE FUNCTION` r=chengxiong-ruan a=chengxiong-ruan

This commit adds to the `REPLACE` path to the
`CREATE OR REPLACE FUNCTION` statement. Major changes are
(1) fetch function with same signature if exists, and validate
(2) remove refereces before replacing the function, and then
    add new references.

Fixes #83236 

Release note: None
Release justification: This commit includes a fix to avoid duplicate functions.

85964: externalconn: add gs support to External Connections r=rhu713 a=adityamaru

This change registers Google Storage `gs` as a supported
External Connection.

Release note (sql change): Users can now
`CREATE EXTERNAL CONNECTION` to represent an underlying
google storage resource.

Release justification: low risk change to new functionality around External Connections

86156: clusterversions: remove RowLevelTTL version r=rafiss a=rafiss

Release justification: low risk change to remove dead code

Release note: None

86179: roachtest: reduce slowness threshold in tpchvec/streamer r=yuzefovich a=yuzefovich

Release note: None

Release justification: test-only change.

86185: grunning: improve some tests r=irfansharif a=irfansharif

Release note: None
Release justification: test-only changes

86219: storage/metamorphic: skip TestPebbleEquivalence r=erikgrinaker a=jbowens

Skip TestPebbleEquivalence until #86102/#86088 is resolved.

Release note: None
Release justification: Non-production code changes.

86222: sql/logictest: attempt to deflake retry errors r=ajwerner a=ajwerner

When we run transactions in logictests, they can be exposed to retry errors.
The framework does not have tools to retry whole blocks. In #58217 we added
a mechanism to skip tests which hit such errors. Apply that logic here.

(hopefully)
Fixes #86215

Release justification: testing only change

Release note: None

86231: sqlsmith: skip crdb_internal.set_compaction_concurrency r=yuzefovich a=yuzefovich

Fixes: #86201

Release justification: test-only change.

Release note: None

Co-authored-by: Chengxiong Ruan <[email protected]>
Co-authored-by: Aditya Maru <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: irfan sharif <[email protected]>
Co-authored-by: Jackson Owens <[email protected]>
Co-authored-by: Andrew Werner <[email protected]>
@craig craig bot closed this as completed in d364c31 Aug 16, 2022
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql/logictest: attempt to deflake retry errors ajwerner/cockroach
1 participant
@cucaroach