Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: add rangedels to BenchmarkMVCCExportToSST #86140

Closed
tbg opened this issue Aug 15, 2022 · 1 comment · Fixed by #86141
Closed

storage: add rangedels to BenchmarkMVCCExportToSST #86140

tbg opened this issue Aug 15, 2022 · 1 comment · Fixed by #86141
Assignees
@tbg
Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@tbg
Copy link
Member

tbg commented Aug 15, 2022 •
edited by exalate-issue-sync bot
Loading

See #83049.

Jira issue: CRDB-18597

Epic CRDB-2624
@tbg tbg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv-replication labels Aug 15, 2022
@tbg tbg self-assigned this Aug 15, 2022
@blathers-crl
Copy link

blathers-crl bot commented Aug 15, 2022

cc @cockroachdb/replication

@blathers-crl blathers-crl bot added the A-kv-replication Relating to Raft, consensus, and coordination. label Aug 15, 2022
@tbg tbg mentioned this issue Aug 15, 2022
Merged
craig bot pushed a commit that referenced this issue Aug 19, 2022
@tbg
Merge #86141
2e8c0f6 
86141: storage: add mvcc rangedels to BenchmarkMVCCExportToSST r=erikgrinaker a=tbg

```
go test ./pkg/storage -run - -timeout 40m -count 10 -benchtime 1s -bench 'MVCCExportToSST' 2>&1 | tee bench.txt && ./bench-compare-params.sh bench.txt numRangeKeys {0,1,100}
```

```
==== old: numRangeKeys=0 new: numRangeKeys=1 ====
name                                                                                       old time/op  new time/op   delta
MVCCExportToSST/numKeys=64/numRevisions=1/exportAllRevisions=false/numRangeKeys=X-24       92.5µs ± 4%  145.7µs ± 9%  +57.51%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=64/numRevisions=1/exportAllRevisions=true/numRangeKeys=X-24        85.5µs ± 2%  146.2µs ±10%  +71.07%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=64/numRevisions=10/exportAllRevisions=false/numRangeKeys=X-24       212µs ± 2%    289µs ± 4%  +36.17%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=64/numRevisions=10/exportAllRevisions=true/numRangeKeys=X-24        351µs ± 4%    455µs ± 2%  +29.53%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=64/numRevisions=100/exportAllRevisions=false/numRangeKeys=X-24      231µs ± 3%    308µs ± 3%  +33.42%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=64/numRevisions=100/exportAllRevisions=true/numRangeKeys=X-24      1.63ms ± 2%   2.09ms ± 2%  +27.97%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=512/numRevisions=1/exportAllRevisions=false/numRangeKeys=X-24       421µs ± 3%    550µs ± 2%  +30.61%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=512/numRevisions=1/exportAllRevisions=true/numRangeKeys=X-24        387µs ± 2%    517µs ± 2%  +33.74%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=512/numRevisions=10/exportAllRevisions=false/numRangeKeys=X-24     1.33ms ± 1%   1.84ms ± 1%  +37.58%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=512/numRevisions=10/exportAllRevisions=true/numRangeKeys=X-24      2.39ms ± 1%   3.17ms ± 2%  +32.63%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=512/numRevisions=100/exportAllRevisions=false/numRangeKeys=X-24    1.46ms ± 1%   1.97ms ± 1%  +34.70%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=512/numRevisions=100/exportAllRevisions=true/numRangeKeys=X-24     12.6ms ± 1%   15.9ms ± 1%  +26.51%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=1024/numRevisions=1/exportAllRevisions=false/numRangeKeys=X-24      761µs ± 2%   1016µs ± 1%  +33.43%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=1024/numRevisions=1/exportAllRevisions=true/numRangeKeys=X-24       705µs ± 2%    948µs ± 1%  +34.44%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=1024/numRevisions=10/exportAllRevisions=false/numRangeKeys=X-24    2.64ms ± 1%   3.58ms ± 1%  +35.74%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=1024/numRevisions=10/exportAllRevisions=true/numRangeKeys=X-24     4.70ms ± 0%   6.25ms ± 1%  +32.90%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=1024/numRevisions=100/exportAllRevisions=false/numRangeKeys=X-24   2.86ms ± 1%   3.84ms ± 1%  +34.11%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=1024/numRevisions=100/exportAllRevisions=true/numRangeKeys=X-24    25.3ms ± 2%   31.5ms ± 1%  +24.55%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=8192/numRevisions=1/exportAllRevisions=false/numRangeKeys=X-24     5.70ms ± 1%   7.41ms ± 1%  +29.97%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=8192/numRevisions=1/exportAllRevisions=true/numRangeKeys=X-24      5.16ms ± 2%   6.86ms ± 2%  +33.11%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=8192/numRevisions=10/exportAllRevisions=false/numRangeKeys=X-24    21.2ms ± 2%   29.1ms ± 2%  +37.18%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=8192/numRevisions=10/exportAllRevisions=true/numRangeKeys=X-24     38.6ms ± 1%   50.0ms ± 1%  +29.55%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=8192/numRevisions=100/exportAllRevisions=false/numRangeKeys=X-24   24.8ms ± 1%   33.4ms ± 3%  +34.73%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=8192/numRevisions=100/exportAllRevisions=true/numRangeKeys=X-24     210ms ± 3%    264ms ± 2%  +25.93%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=65536/numRevisions=1/exportAllRevisions=false/numRangeKeys=X-24    45.1ms ± 1%   58.6ms ± 1%  +30.02%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=65536/numRevisions=1/exportAllRevisions=true/numRangeKeys=X-24     40.9ms ± 1%   54.1ms ± 1%  +32.40%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=65536/numRevisions=10/exportAllRevisions=false/numRangeKeys=X-24    183ms ± 1%    244ms ± 0%  +33.19%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=65536/numRevisions=10/exportAllRevisions=true/numRangeKeys=X-24     314ms ± 0%    413ms ± 2%  +31.33%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=65536/numRevisions=100/exportAllRevisions=false/numRangeKeys=X-24   260ms ±10%    331ms ±11%  +27.50%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=65536/numRevisions=100/exportAllRevisions=true/numRangeKeys=X-24    1.83s ± 1%    2.27s ± 1%  +24.03%  (p=0.008 n=5+5)
```

```
==== old: numRangeKeys=0 new: numRangeKeys=100 ====
name                                                                                       old time/op  new time/op    delta
MVCCExportToSST/numKeys=64/numRevisions=1/exportAllRevisions=false/numRangeKeys=X-24       92.5µs ± 4%  5081.4µs ± 0%  +5391.36%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=64/numRevisions=1/exportAllRevisions=true/numRangeKeys=X-24        85.5µs ± 2%  5083.3µs ± 1%  +5848.68%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=64/numRevisions=10/exportAllRevisions=false/numRangeKeys=X-24       212µs ± 2%    5283µs ± 1%  +2387.43%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=64/numRevisions=10/exportAllRevisions=true/numRangeKeys=X-24        351µs ± 4%    5385µs ± 1%  +1432.41%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=64/numRevisions=100/exportAllRevisions=false/numRangeKeys=X-24      231µs ± 3%    5318µs ± 1%  +2200.66%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=64/numRevisions=100/exportAllRevisions=true/numRangeKeys=X-24      1.63ms ± 2%    7.06ms ± 1%   +332.92%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=512/numRevisions=1/exportAllRevisions=false/numRangeKeys=X-24       421µs ± 3%   15413µs ± 1%  +3562.62%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=512/numRevisions=1/exportAllRevisions=true/numRangeKeys=X-24        387µs ± 2%   15127µs ± 2%  +3810.76%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=512/numRevisions=10/exportAllRevisions=false/numRangeKeys=X-24     1.33ms ± 1%   17.30ms ± 2%  +1196.69%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=512/numRevisions=10/exportAllRevisions=true/numRangeKeys=X-24      2.39ms ± 1%   18.16ms ± 2%   +659.80%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=512/numRevisions=100/exportAllRevisions=false/numRangeKeys=X-24    1.46ms ± 1%   17.67ms ± 1%  +1109.77%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=512/numRevisions=100/exportAllRevisions=true/numRangeKeys=X-24     12.6ms ± 1%    31.3ms ± 1%   +148.91%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=1024/numRevisions=1/exportAllRevisions=false/numRangeKeys=X-24      761µs ± 2%   18560µs ± 1%  +2338.25%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=1024/numRevisions=1/exportAllRevisions=true/numRangeKeys=X-24       705µs ± 2%   18309µs ± 0%  +2497.43%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=1024/numRevisions=10/exportAllRevisions=false/numRangeKeys=X-24    2.64ms ± 1%   23.30ms ± 1%   +783.25%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=1024/numRevisions=10/exportAllRevisions=true/numRangeKeys=X-24     4.70ms ± 0%   24.54ms ± 1%   +422.09%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=1024/numRevisions=100/exportAllRevisions=false/numRangeKeys=X-24   2.86ms ± 1%   23.76ms ± 1%   +729.73%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=1024/numRevisions=100/exportAllRevisions=true/numRangeKeys=X-24    25.3ms ± 2%    51.2ms ± 1%   +102.28%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=8192/numRevisions=1/exportAllRevisions=false/numRangeKeys=X-24     5.70ms ± 1%   32.34ms ± 3%   +467.60%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=8192/numRevisions=1/exportAllRevisions=true/numRangeKeys=X-24      5.16ms ± 2%   31.52ms ± 2%   +511.28%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=8192/numRevisions=10/exportAllRevisions=false/numRangeKeys=X-24    21.2ms ± 2%    76.5ms ± 2%   +260.02%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=8192/numRevisions=10/exportAllRevisions=true/numRangeKeys=X-24     38.6ms ± 1%    86.6ms ± 1%   +124.44%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=8192/numRevisions=100/exportAllRevisions=false/numRangeKeys=X-24   24.8ms ± 1%    86.1ms ± 1%   +247.75%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=8192/numRevisions=100/exportAllRevisions=true/numRangeKeys=X-24     210ms ± 3%     305ms ± 2%    +45.62%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=65536/numRevisions=1/exportAllRevisions=false/numRangeKeys=X-24    45.1ms ± 1%    77.3ms ± 2%    +71.41%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=65536/numRevisions=1/exportAllRevisions=true/numRangeKeys=X-24     40.9ms ± 1%    73.0ms ± 1%    +78.62%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=65536/numRevisions=10/exportAllRevisions=false/numRangeKeys=X-24    183ms ± 1%     411ms ± 1%   +124.65%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=65536/numRevisions=10/exportAllRevisions=true/numRangeKeys=X-24     314ms ± 0%     520ms ± 1%    +65.46%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=65536/numRevisions=100/exportAllRevisions=false/numRangeKeys=X-24   260ms ±10%     857ms ± 3%   +229.61%  (p=0.008 n=5+5)
MVCCExportToSST/numKeys=65536/numRevisions=100/exportAllRevisions=true/numRangeKeys=X-24    1.83s ± 1%     2.63s ± 2%    +44.05%  (p=0.008 n=5+5)
```

Closes #86140.

Release note: None
Release justification: testing-only changes


Co-authored-by: Tobias Grieger <[email protected]>
@craig craig bot closed this as completed in 752faa1 Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

storage: add mvcc rangedels to BenchmarkMVCCExportToSST tbg/cockroach
1 participant
@tbg