-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: cdc/schemareg failed #84789
Comments
roachtest.cdc/schemareg failed with artifacts on master @ fafc3330130a016a881592d0337ec48d9ce43b61:
Parameters: |
roachtest.cdc/schemareg failed with artifacts on master @ 8fd5b3500796fae41c07fffd4246648b349b6460:
Parameters: |
roachtest.cdc/schemareg failed with artifacts on master @ eabdc49383a19d5731b765dbb0d8b45bd9e24404:
Parameters: |
roachtest.cdc/schemareg failed with artifacts on master @ eabdc49383a19d5731b765dbb0d8b45bd9e24404:
Parameters: |
This is probably the new drop column implementation |
roachtest.cdc/schemareg failed with artifacts on master @ 8db26695114981eec5c12317f3dc5d770b522a3f:
Parameters: |
roachtest.cdc/schemareg failed with artifacts on master @ 0f100f3a09246bc80ef2c3119e4ec1c24ef36801:
Parameters: |
roachtest.cdc/schemareg failed with artifacts on master @ 7c95ccd0a9f0b0aca9cdb0ed813caf8d60b28732:
Parameters: |
roachtest.cdc/schemareg failed with artifacts on master @ 1129fbc650fe3a037b03aea1e5f1d8078618cb1c:
Parameters: |
85199: sql: move function properties to overload level r=chengxiong-ruan a=chengxiong-ruan There're 3 commits: (1) sql: use Overload in FunctionDefinition instead of overloadImpl It feels a bit annoying to always need to cast overloadImpl to Overload. In fact, all `overloadImpl`s in FunctionDefinition are `Overload`s (2) sql: move function properties to overload level Moving function propterties to overload level, but still keep it in FunctionDefiniton since it's still needed for internal usage like docgen. Later on, the function resolution interface will return a resolved version of function definition which won't have the properties field. Instead, we'll go through overloads to fetch properties for resolved function definition. Current FunctionDefiniton will be kept for builtin functions only. (3) sql: remove usage of GetBuiltinProperties from GetSequenceFromFunc In `GetSequenceFromFunc` we resolve a functiong and then use the name to get builtin properties. This seems unnecessary because we may just get function properties from the resolved function definition. With this change, we are eleminating a good amount of usage cases of "GetBuiltinProperties", which seems to be the majority of the usages of "GetBuiltinProperties". There shouldn't be any functionality changes since we don't have UDFs yet. 85259: roachtest: fix cdc/schemareg r=ajwerner a=ajwerner Now that DROP COLUMN uses the declarative schema changer, you no longer see touch writes. Fixes #84789 Release note: None 85281: backupccl: show backup was incorrectly capturing a ctx r=yuzefovich a=adityamaru This diff fixes a span use after finish that was a result of show backup code incorrectly capturing a context. Fixes: #85201 Release note: None 85284: dev: fix `test --changed` when no files are changed r=rail a=rickystewart With the previous version of the code this would fail with a confusing error message if no files were changed. Release note: None Co-authored-by: Chengxiong Ruan <[email protected]> Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: Aditya Maru <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
roachtest.cdc/schemareg failed with artifacts on master @ 457d724622e4fa2e62d6f4e7926509dbc7d18511:
Parameters:
ROACHTEST_cloud=gce
,ROACHTEST_cpu=4
,ROACHTEST_ssd=0
Help
See: roachtest README
See: How To Investigate (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-17862
Epic CRDB-11732
The text was updated successfully, but these errors were encountered: