Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: timeout in TestAlterChangefeedDatabaseQualifiedNames #83253

Closed
ajwerner opened this issue Jun 23, 2022 · 4 comments · Fixed by #83530
Closed

changefeedccl: timeout in TestAlterChangefeedDatabaseQualifiedNames #83253

ajwerner opened this issue Jun 23, 2022 · 4 comments · Fixed by #83530
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cdc

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Jun 23, 2022 •
edited by cockroach-jira-scripts
Loading

Describe the problem

https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_EssentialCi/5537804?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildDeploymentsSection=true

Jira issue: CRDB-16952
@ajwerner ajwerner added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-cdc Change Data Capture labels Jun 23, 2022
@blathers-crl blathers-crl bot added the T-cdc label Jun 23, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jun 23, 2022

cc @cockroachdb/cdc

@ajwerner ajwerner changed the title changefeedccl: timeout in TestChangefeedDatabaseQualifiedNames changefeedccl: timeout in TestAlterChangefeedDatabaseQualifiedNames Jun 23, 2022
@ajwerner
Copy link
Contributor Author

https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_UnitTests_Test/5537797?buildTab=artifacts

@HonoreDB
Copy link
Contributor

This might just be because several ALTER CHANGEFEED tests set resolved to 100ms or 1s. But since I don't know why they do that I'm not confident we can just magically make the tests faster by shrinking those numbers.

@adityamaru adityamaru mentioned this issue Jun 27, 2022
Merged
@samiskin samiskin mentioned this issue Jun 28, 2022
Merged
craig bot pushed a commit that referenced this issue Jun 29, 2022
@samiskin
Merge #83530
7072623 
83530: changefeedccl: do not error out on checkpoint during pause-requested r=samiskin a=samiskin

Resolves #83253

Previously there was a race condition where we could attempt to
checkpoint while the job was in a pause-requested state and would
error out.  Since the changefeed should still be running normally 
during *-requested states this should not error.

Release note (bug fix): Changefeeds no longer error out when attempting
to checkpoint during intermediate pause-requested or cancel-requested
states.

Co-authored-by: Shiranka Miskin <[email protected]>
@craig craig bot closed this as completed in 0707e55 Jun 29, 2022
blathers-crl bot pushed a commit that referenced this issue Jun 29, 2022
@samiskin
changefeedccl: do not error out on checkpoint during pause-requested
d64ff20 
Resolves #83253

Previously there was a race condition where we would attempt to
checkpoint while the job was in a pause-requested state.  Since the
changefeed should still be running normally during requested states this
should not error.

Release note (bug fix): Changefeeds no longer error out when attempting
to checkpoint during intermediate pause-requested or cancel-requested
states.
@blathers-crl blathers-crl bot mentioned this issue Jun 29, 2022
Merged
@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented Jun 29, 2022 •
edited
Loading

Here is a failure of this issue.
See https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_UnitTests_Test/5602404?buildTab=artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cdc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changefeedccl: do not error out on checkpoint during pause-requested samiskin/cockroach
3 participants
@HonoreDB @ajwerner @Xiang-Gu