Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: INSERT ON CONFLICT behaves differently in opt test than demo #76994

Closed
mgartner opened this issue Feb 24, 2022 · 0 comments · Fixed by #78435
Closed

opt: INSERT ON CONFLICT behaves differently in opt test than demo #76994

mgartner opened this issue Feb 24, 2022 · 0 comments · Fixed by #78435
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team

Comments

@mgartner
Copy link
Collaborator

mgartner commented Feb 24, 2022

The follow test results in an error, but the same statements are successful in the demo. This is likely an inconsistency between the test catalog and the opt catalog:

exec-ddl
CREATE TABLE uniq_constraint_and_partial_index (
  k INT PRIMARY KEY,
  a INT,
  b INT,
  UNIQUE INDEX (a) WHERE b > 11,
  UNIQUE WITHOUT INDEX (a) WHERE b < -1,
  UNIQUE WITHOUT INDEX (a) WHERE b > 0
)
----


norm
INSERT INTO uniq_constraint_and_partial_index VALUES (2, 2, 2)
ON CONFLICT (a) WHERE b > 10 DO NOTHING
----

Jira issue: CRDB-13362

@mgartner mgartner added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Feb 24, 2022
@mgartner mgartner self-assigned this Feb 24, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Feb 24, 2022
craig bot pushed a commit that referenced this issue Mar 28, 2022
78435: opt: fix deduplication of unique constraints in test catalog r=mgartner a=mgartner

This commit fixes a bug in the test catalog which incorrectly
de-duplicated unique constraints that had the same columns but different
predicates.

Fixes #76994

Release note: None

78524: zcfg: rename UpdateZoneConfigForTables to RefreshZoneConfigsForTable r=arulajmani a=RichardJCai

Release note: None

Fixes #77641

78533: ui: don't download .dll.js bundles r=sjbarag a=sjbarag

Loading the CockroachDB admin UI (served from port 8080) would previously download three JS files: `bundle.js`, `vendor.dll.js`, and `protos.dll.js`. Neither `vendor.dll.js` nor `protos.dll.js` need to be included via `<script/>` tag, as they're used only as build-time tooling to accelerate webpack builds. Only a single file -- `bundle.js` -- needs to be loaded for the admin UI to be functional, and Bazel-produced builds don't have any `.dll.js` files to serve. Don't load `.dll.js` files via index.html.

Since dll file aren't being served directly to users anymore, there's no need to embed them in the `cockroach` binary. Stop copying `.dll.js` files into `pkg/ui/dist{oss,ccl}` during builds, reducing the `cockroach` binary size by ~19MB (darwin, x86) when built with GNU make.

78607: sqlsmith: skip crdb_internal.complete_replication_stream r=rytaft a=rytaft

Don't use crdb_internal.complete_replication_stream when generating
sqlsmith queries, since it currently causes a panic.

Informs #78553

Release note: None

78609: cli: de-flake TestDockerCLI/test_demo_node_cmds.tcl r=ajwerner a=tbg

Touches #76391.
(Not closing since `@ajwerner` requested so)

This test is very flaky, so we need a stop-gap. It's also not really useful to get into the gossip info from a cli test.

Release note: None


Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: richardjcai <[email protected]>
Co-authored-by: Sean Barag <[email protected]>
Co-authored-by: Rebecca Taft <[email protected]>
Co-authored-by: Tobias Grieger <[email protected]>
@craig craig bot closed this as completed in 381ec09 Mar 28, 2022
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant