Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'Clear' SQL stats to 'Reset in the console #73444

Closed
kevin-v-ngo opened this issue Dec 3, 2021 · 0 comments · Fixed by #73922
Closed

Update 'Clear' SQL stats to 'Reset in the console #73444

kevin-v-ngo opened this issue Dec 3, 2021 · 0 comments · Fixed by #73922
Assignees
@matthewtodd
Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@kevin-v-ngo
Copy link

kevin-v-ngo commented Dec 3, 2021 •
edited
Loading

We should have consistency in our console (DB and CC) and the SQL CLI (crdb_internal). As described here, we should update the text 'Clear' SQL stats button on statements/transactions pages to 'Reset'.

Epic: CRDB-11997
@kevin-v-ngo kevin-v-ngo added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Dec 3, 2021
@kevin-v-ngo kevin-v-ngo added the A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console label Dec 3, 2021
@matthewtodd matthewtodd self-assigned this Dec 16, 2021
@matthewtodd matthewtodd mentioned this issue Dec 16, 2021
Merged
craig bot pushed a commit that referenced this issue Dec 16, 2021
@dhartunian @knz @matthewtodd
Merge #73821 #73905 #73922
db6851b 
73821: tracing: tenant redaction test uses tracing knobs r=dhartunian a=dhartunian

Previously, the tenant redaction test manually read back the results of
traces in SQL. Since we have a testing knob for this purpose it makes
sense to use it here and collect the traces in a more straightforward
way.

This test now also uses the `trace.redactability.enabled` cluster
setting instead of setting the redactability flag on the tracer to test
that the cluster setting is correctly connected.

Release note: None

73905: envutil: avoid importing `testing` in non-test code r=dt,JeffSwenson a=knz

Thanks to @dt for [noticing](#69115 (review)).

Release note: None

73922: ui: say "reset" SQL stats instead of "clear" r=matthewtodd a=matthewtodd

Fixes #73444

Release note (ui change): The "clear SQL stats" links on the statement
and transaction pages were relabeled "reset SQL stats," for consistency
with the language in the SQL shell.

Co-authored-by: David Hartunian <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Matthew Todd <[email protected]>
@craig craig bot closed this as completed in 18f68a2 Dec 16, 2021
@blathers-crl blathers-crl bot mentioned this issue Jan 4, 2022
Merged
blathers-crl bot pushed a commit that referenced this issue Jan 4, 2022
@matthewtodd
ui: say "reset" SQL stats instead of "clear"
c402fcc 
Fixes #73444

Release note (ui change): The "clear SQL stats" links on the statement
and transaction pages were relabeled "reset SQL stats," for consistency
with the language in the SQL shell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewtodd matthewtodd

Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: say "reset" SQL stats instead of "clear"
2 participants
@matthewtodd @kevin-v-ngo