Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: check generated files CI job can fail without informative output #72245

Closed
rickystewart opened this issue Oct 29, 2021 · 1 comment · Fixed by #72246
Closed

ci: check generated files CI job can fail without informative output #72245

rickystewart opened this issue Oct 29, 2021 · 1 comment · Fixed by #72246
Assignees
@rickystewart
Labels
A-ci Continuous Integration C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

ex. https://teamcity.cockroachdb.com/viewLog.html?buildId=3656885&tab=buildResultsDiv&buildTypeId=Cockroach_UnitTests_CheckGeneratedCode

This output is missing:

Detected an unknown //go:generate comment:
pkg/roachprod/vm/aws/config.go://go:generate terraformgen -o terraform/main.tf
Please ensure that the equivalent logic to generate these files is
present in the Bazel build as well, then add the line to the
EXISTING_GO_GENERATE_COMMENTS in build/bazelutil/check-genfiles.sh.
Also see https://cockroachlabs.atlassian.net/wiki/spaces/CRDB/pages/1380090083/How+to+ensure+your+code+builds+with+Bazel

Epic CRDB-8351
@rickystewart rickystewart added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf A-ci Continuous Integration labels Oct 29, 2021
@rickystewart
Copy link
Collaborator Author

Also the filename as reported by the error message is wrong.

@rickystewart rickystewart self-assigned this Oct 29, 2021
@rickystewart rickystewart mentioned this issue Oct 29, 2021
Merged
craig bot pushed a commit that referenced this issue Oct 29, 2021
@rickystewart @tbg
Merge #72098 #72237 #72246
db229ca 
72098: roachtest: fix up `mockgen` usage w/ Bazel r=irfansharif a=rickystewart

We were pointing to the checked-in generated files in the Bazel build
here; instead, use `gomock`.

Also clean up the `EXISTING_GO_GENERATE_COMMENTS` in
`build/bazelutil/check.sh`.

Release note: None

72237: kvserver: remove detritus for old change replicas and preemptive snaps r=nvanbenschoten a=tbg

See individual commits.

- kvserver: remove deprecated fields in ChangeReplicasTrigger
- kvserver: improve comment on raft send buffer size
- kvserver: improve comment on split trigger helper
- kvserver: remove TODO for removing DisableEagerReplicaRemoval
- kvserver: remove snapshot CanDecline flag
- kvserver: reflect absence of preemptive snaps in more comments
- kvserver: remove IsPreemptive()
- kvserver: bump snapshotReservationWaitWarnThreshold
- kvserver: add TODO about removing snapshot log sending code.
- kvserver: assert that local descriptor "always" contains the replica
- kvserver: remove env-defaults for snapshot rate limits

Release note: None


72246: ci: make sure `check generated files` output is dumped if check fails r=rail a=rickystewart

Closes #72245.

Release note: None

Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Tobias Grieger <[email protected]>
@craig craig bot closed this as completed in 936d157 Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickystewart rickystewart

Labels
A-ci Continuous Integration C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: make sure check generated files output is dumped if check fails rickystewart/cockroach
1 participant
@rickystewart