Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: introduce RPCs to allow configuring KV spans #66391

Closed
irfansharif opened this issue Jun 11, 2021 · 2 comments · Fixed by #66877
Closed

kvserver: introduce RPCs to allow configuring KV spans #66391

irfansharif opened this issue Jun 11, 2021 · 2 comments · Fixed by #66877
Assignees
@irfansharif
Labels
A-multitenancy Related to multi-tenancy A-zone-configs C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@irfansharif
Copy link
Contributor

irfansharif commented Jun 11, 2021 •
edited
Loading

Part of #66348. We'll want to provide the APIs through which active SQL pods and the host tenant will install KV span configs for its descriptor objects. This should happen transactionally on the KV side; span configs will be written to the table introduced in #66390. We can start off with the simple "bulk update" form for the RPC, assuming just a single SQL pod per-tenant.
@blathers-crl
Copy link

blathers-crl bot commented Jun 11, 2021

Hi @irfansharif, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@irfansharif irfansharif added A-multitenancy Related to multi-tenancy A-zone-configs labels Jun 11, 2021
@irfansharif irfansharif changed the title kvserver: introduce RPC to allow configuring KV spans kvserver: introduce RPCs to allow configuring KV spans Jun 12, 2021
This was referenced Jun 12, 2021
Closed
Closed
@irfansharif irfansharif added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jun 12, 2021
@irfansharif irfansharif self-assigned this Jun 14, 2021
irfansharif added a commit to irfansharif/cockroach that referenced this issue Jun 25, 2021
@irfansharif
[prototype] kv,roachpb: introduce basic span config rpcs
ecc902e 
And expose it through kvtenant.Connector. Also flesh out the SpanConfig
proto type (it's the same as ZoneConfig, but without any inheritance
business).

Closes cockroachdb#66391.
Closes cockroachdb#66395.

Release note: None
@irfansharif irfansharif mentioned this issue Jun 25, 2021
Merged
@irfansharif irfansharif linked a pull request Jun 25, 2021 that will close this issue
[prototype] kv,roachpb: introduce basic span config rpcs #66877
Merged
irfansharif added a commit to irfansharif/cockroach that referenced this issue Jun 28, 2021
@irfansharif
[prototype] kv,roachpb: introduce basic span config rpcs
c9f2ef1 
And expose it through kvtenant.Connector. Also flesh out the SpanConfig
proto type (it's the same as ZoneConfig, but without any inheritance
business).

Closes cockroachdb#66391.
Closes cockroachdb#66395.

Release note: None
@irfansharif
Copy link
Contributor Author

#66877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irfansharif irfansharif

Labels
A-multitenancy Related to multi-tenancy A-zone-configs C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[prototype] kv,roachpb: introduce basic span config rpcs irfansharif/cockroach
1 participant
@irfansharif