Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken tests in Bazel under pkg/cmd #61924

Closed
rickystewart opened this issue Mar 12, 2021 · 0 comments · Fixed by #106206
Closed

broken tests in Bazel under pkg/cmd #61924

rickystewart opened this issue Mar 12, 2021 · 0 comments · Fixed by #106206
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

rickystewart commented Mar 12, 2021 •
edited by cockroach-jira-scripts
Loading

The following tests are all broken in Bazel:

pkg/cmd/github-post
pkg/cmd/publish-artifacts
pkg/cmd/roachtest
pkg/cmd/teamcity-trigger
pkg/cmd/prereqs
pkg/cmd/cockroach-oss

There's a lot going on here, but I think generally all these tests expect to be run from the root of the checkout.

Jira issue: CRDB-2711
@rickystewart rickystewart added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Mar 12, 2021
@rickystewart rickystewart mentioned this issue Jul 5, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 7, 2023
@rickystewart @irfansharif
Merge #106206 #106343 #106411
42922d0 
106206: prereqs: delete tests r=rail a=rickystewart

These tests have always been skipped under Bazel because the implementation doesn't work in a Bazel world due to the dependency on `"golang.org/x/tools/go/packages"`. Since the command is only useful/ used in `make`, which is going to be deleted shortly, just delete the tests rather than waste time getting it working.

Also this is the last `broken_in_bazel` test, so rip out all the corresponding
logic too.

Epic: none
Release note: None
Closes: #61924
Closes: #92814

106343: ci: don't do retries on tests in CI on master, release branches r=rail a=rickystewart

First of all, test retries don't even have the correct behavior: #103042
This means that a successfully-retried test tramples the logs of
previously-failed tests, which is very confusing and erases your ability
to debug the test.

Also, we are focusing on quality and wiping out flaky and skipped tests.
This to me suggests we should not be retrying tests to let already-flaky
tests through. Rather, we should be surfacing real failures immediately.

For both of these reasons I turn off test retries for unit tests on
`master` and release branches.

We keep it for `staging` so `bors` is unaffected.

Epic: none
Release note: None

106411: kvflowhandle: fix mutex leak r=irfansharif a=irfansharif

Fixes #106078.

We were forgetting to unlock the mutex on the error path.

Release note: None

Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: irfan sharif <[email protected]>
@craig craig bot closed this as completed in 9ed7b15 Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prereqs: delete tests rickystewart/cockroach
2 participants
@jlinder @rickystewart