Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: use catalog.TableDescriptor instead of tabledesc.Immutable #59486

Closed
postamar opened this issue Jan 27, 2021 · 0 comments · Fixed by #59495
Closed

sql: use catalog.TableDescriptor instead of tabledesc.Immutable #59486

postamar opened this issue Jan 27, 2021 · 0 comments · Fixed by #59495
Assignees
@postamar
Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@postamar
Copy link
Contributor

This is a child of #56306. Should be self-explanatory.
@postamar postamar added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jan 27, 2021
@postamar postamar mentioned this issue Jan 27, 2021
Closed
@postamar postamar added the A-schema-descriptors Relating to SQL table/db descriptor handling. label Jan 27, 2021
@postamar postamar self-assigned this Jan 27, 2021
@postamar postamar mentioned this issue Jan 27, 2021
Merged
postamar pushed a commit to postamar/cockroach that referenced this issue Jan 29, 2021
sql: use catalog.TableDescriptor instead of tabledesc.Immutable
367f206 
Previously we tended to use the concrete tabledesc.Immutable type
rather than the catalog.TableDescriptor type. This was mainly for
historical reasons because the former predates the latter. This patch
builds on my previous commits by switching to the interface type
everywhere outside of the tabledesc package.

This required making the MakeImmutable factory function in tabledesc
private, and changing the signatures of the NewImmutable factory
functions and using them instead of MakeImmutable.

Fixes cockroachdb#59486.

Release note: None
craig bot pushed a commit that referenced this issue Feb 2, 2021
Merge #59495
e854509 
59495: sql: use catalog.TableDescriptor instead of tabledesc.Immutable r=postamar a=postamar

This PR makes the tabledesc.Immutable type private and makes use of the
catalog.TableDescriptor interface instead.

Fixes #59486.

Release note: None 

Co-authored-by: Marius Posta <[email protected]>
@craig craig bot closed this as completed in 6c5acc2 Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@postamar postamar

Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: use catalog.TableDescriptor instead of tabledesc.Immutable postamar/cockroach
1 participant
@postamar