-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: decommission/randomized failed #55581
Comments
(roachtest).decommission/randomized failed on master@47044feed11ec0c0390989bf8f44e777ec3eb00d:
More
Artifacts: /decommission/randomized See this test on roachdash |
(roachtest).decommission/randomized failed on master@b1abf9c8dfb5880fce69dfc7240e593f077bf77c:
More
Artifacts: /decommission/randomized See this test on roachdash |
(roachtest).decommission/randomized failed on master@d752fa2bd9afad255e8c655de9c7edc6dad14486:
More
Artifacts: /decommission/randomized See this test on roachdash |
(roachtest).decommission/randomized failed on master@ab503e2fd708541e5e9ebb9a6f2651eda506f2ef:
More
Artifacts: /decommission/randomized See this test on roachdash |
This also fails as a result of #55286. This test is using decommissioned nodes to run cli commands, but since these nodes are locked out hard from the cluster now, this times out. Will need to rework the test harness to always pick "up" nodes for the commands. |
Some issues in this test.
We're seeing issue 4) here, which is straightforward to fix. For the issue in 1), I'll slightly derandomize the test to always target n1 in that step, which is guaranteed to have replicas. Will send PR. |
(roachtest).decommission/randomized failed on master@1d46df77dbd8721cccf508fb5ed498f3de78022c:
More
Artifacts: /decommission/randomized See this test on roachdash |
(roachtest).decommission/randomized failed on master@40b7942025de0d8e347d25451611ad2c20267d48:
More
Artifacts: /decommission/randomized See this test on roachdash |
(roachtest).decommission/randomized failed on master@4702643dd0755a48365a115c970415fbb5023ad2:
More
Artifacts: /decommission/randomized See this test on roachdash |
(roachtest).decommission/randomized failed on master@8aceac3c99c3addece3a9ef9af04cc74715cdb37:
More
Artifacts: /decommission/randomized See this test on roachdash |
(roachtest).decommission/randomized failed on master@6184870a438ae34afbcf29dda5452345dc7587d3:
More
Artifacts: /decommission/randomized See this test on roachdash |
(roachtest).decommission/randomized failed on master@5e3c201595fc33b0d120057c61413195716f811d:
More
Artifacts: /decommission/randomized See this test on roachdash |
55560: backupccl: avoid div-by-zero crash on failed node count r=dt a=dt We've seen a report of a node that crashed due to a divide-by-zero hit during metrics collection, specifically when computing the throughput-per-node by dividing the backup size by node count. Since this is only now used for that metric, make a failure to count nodes a warning only for release builds (and fallback to 1), and make any error while counting, or not counting to more than 0, a returned error in non-release builds. Release note (bug fix): avoid crashing when BACKUP is unable to count the total nodes in the cluster. 55809: roachtest: fix decommission/randomize r=irfansharif a=tbg The test could end up using fully decommissioned nodes for cli commands, which does not work as of #55286. Fixes #55581. Release note: None 56019: lexbase: pin `reserved_keywords.go` within Bazel r=irfansharif a=irfansharif It's an auto-generated file that bazel doesn't yet know how to construct within the sandbox. Before this PR `make bazel-generate` would show spurious diffs on a clean checkout without this file present. Now it no longer will. Unfortunately it also means that successful bazel builds require `reserved_keywords.go` being pre-generated ahead of time (it's not checked-in into the repo). Once Bazel is taught to generate this file however, this will no longer be the case. It was just something that I missed in #55687. Release note: None Co-authored-by: David Taylor <[email protected]> Co-authored-by: Tobias Grieger <[email protected]> Co-authored-by: irfan sharif <[email protected]>
The test could end up using fully decommissioned nodes for cli commands, which does not work as of cockroachdb#55286. Additionally, decommissioned nodes now become non-live after a short while, so various cli output checks had to be adjusted. Fixes cockroachdb#55581. Release note: None
(roachtest).decommission/randomized failed on master@80e7127197f76ef35c1f6ec3984c4d49d4afde7f:
More
Artifacts: /decommission/randomized
See this test on roachdash
powered by pkg/cmd/internal/issues
The text was updated successfully, but these errors were encountered: