Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: activerecord failed #51532

Closed
cockroach-teamcity opened this issue Jul 17, 2020 · 1 comment · Fixed by #51557
Closed

roachtest: activerecord failed #51532

cockroach-teamcity opened this issue Jul 17, 2020 · 1 comment · Fixed by #51557
Assignees
@rafiss
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone
20.2

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).activerecord failed on provisional_202007162030_v20.2.0-alpha.2@dfd3728e46c77e99b6e76fc33dfd344ff0d09cdd:

The test failed on branch=provisional_202007162030_v20.2.0-alpha.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/activerecord/run_1
	cluster.go:1996,activerecord.go:39,activerecord.go:234,test_runner.go:757: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod start teamcity-2095963-1594953847-16-n1cpu4:1 returned: exit status 1
		(1) /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod start teamcity-2095963-1594953847-16-n1cpu4:1 returned
		  | stderr:
		  |
		  | stdout:
		  | teamcity-2095963-1594953847-16-n1cpu4: starting.
		  | 0: ~ ulimit -c unlimited; mkdir -p ${HOME}/logs; echo ">>> roachprod start: $(date)" >> ${HOME}/logs/roachprod.log; ps axeww -o pid -o command >> ${HOME}/logs/roachprod.log; [ -x /usr/bin/lslocks ] && /usr/bin/lslocks >> ${HOME}/logs/roachprod.log;  export ROACHPROD=1 && GOTRACEBACK=crash COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING=1 COCKROACH_DEV_LICENSE=crl-0-EJL04ukFGAEiI0NvY2tyb2FjaCBMYWJzIC0gUHJvZHVjdGlvbiBUZXN0aW5n COCKROACH_BINARY=/home/agent/work/.go/src/github.com/cockroachdb/cockroach/cockroach.linux-2.6.32-gnu-amd64 COCKROACH_ENABLE_RPC_COMPRESSION=false ./cockroach start-single-node --insecure --store=path=/mnt/data1/cockroach --log-dir=${HOME}/logs --background --cache=25% --max-sql-memory=25% --port=26257 --http-port=26258 --locality=cloud=gce,region=us-central1,zone=us-central1-b --join=35.238.245.86:26257 --advertise-host=$(hostname -I | awk '{print $1}') >> ${HOME}/logs/cockroach.stdout.log 2>> ${HOME}/logs/cockroach.stderr.log || (x=$?; cat ${HOME}/logs/cockroach.stderr.log; exit $x): exit status 1
		  | (1) attached stack trace
		  |   | github.com/cockroachdb/cockroach/pkg/cmd/roachprod/install.Cockroach.Start.func2
		  |   | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/install/cockroach.go:296
		  |   | github.com/cockroachdb/cockroach/pkg/cmd/roachprod/install.(*SyncedCluster).Parallel.func1.1
		  |   | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/install/cluster_synced.go:1644
		  |   | runtime.goexit
		  |   | 	/usr/local/go/src/runtime/asm_amd64.s:1373
		  | Wraps: (2) 3 safe details enclosed
		  | Wraps: (3) ~ ulimit -c unlimited; mkdir -p ${HOME}/logs; echo ">>> roachprod start: $(date)" >> ${HOME}/logs/roachprod.log; ps axeww -o pid -o command >> ${HOME}/logs/roachprod.log; [ -x /usr/bin/lslocks ] && /usr/bin/lslocks >> ${HOME}/logs/roachprod.log;  export ROACHPROD=1 && GOTRACEBACK=crash COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING=1 COCKROACH_DEV_LICENSE=crl-0-EJL04ukFGAEiI0NvY2tyb2FjaCBMYWJzIC0gUHJvZHVjdGlvbiBUZXN0aW5n COCKROACH_BINARY=/home/agent/work/.go/src/github.com/cockroachdb/cockroach/cockroach.linux-2.6.32-gnu-amd64 COCKROACH_ENABLE_RPC_COMPRESSION=false ./cockroach start-single-node --insecure --store=path=/mnt/data1/cockroach --log-dir=${HOME}/logs --background --cache=25% --max-sql-memory=25% --port=26257 --http-port=26258 --locality=cloud=gce,region=us-central1,zone=us-central1-b --join=35.238.245.86:26257 --advertise-host=$(hostname -I | awk '{print $1}') >> ${HOME}/logs/cockroach.stdout.log 2>> ${HOME}/logs/cockroach.stderr.log || (x=$?; cat ${HOME}/logs/cockroach.stderr.log; exit $x)
		  |   | E200717 02:47:19.637715 1 cli/error.go:375  ERROR: cannot use --join with 'cockroach start-single-node' -- use 'cockroach start' instead
		  |   | ERROR: cannot use --join with 'cockroach start-single-node' -- use 'cockroach start' instead
		  |   | Failed running "start-single-node"
		  | Wraps: (4) exit status 1
		  | Error types: (1) *withstack.withStack (2) *safedetails.withSafeDetails (3) *errutil.withMessage (4) *exec.ExitError: 
		  | I200717 02:47:19.669595 1 cluster_synced.go:1726  command failed
		Wraps: (2) exit status 1
		Error types: (1) *main.withCommandDetails (2) *exec.ExitError
More

Artifacts: /activerecord

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. branch-provisional_202007162030_v20.2.0-alpha.2 labels Jul 17, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Jul 17, 2020
@cockroach-teamcity cockroach-teamcity mentioned this issue Jul 17, 2020
Closed
@irfansharif irfansharif mentioned this issue Jul 17, 2020
Merged
@cockroach-teamcity
Copy link
Member Author

(roachtest).activerecord failed on provisional_202007162030_v20.2.0-alpha.2@dfd3728e46c77e99b6e76fc33dfd344ff0d09cdd:

The test failed on branch=provisional_202007162030_v20.2.0-alpha.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/activerecord/run_1
	cluster.go:1996,activerecord.go:39,activerecord.go:234,test_runner.go:757: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod start teamcity-2098053-1595010578-16-n1cpu4:1 returned: exit status 1
		(1) /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod start teamcity-2098053-1595010578-16-n1cpu4:1 returned
		  | stderr:
		  |
		  | stdout:
		  | teamcity-2098053-1595010578-16-n1cpu4: starting.
		  | 0: ~ ulimit -c unlimited; mkdir -p ${HOME}/logs; echo ">>> roachprod start: $(date)" >> ${HOME}/logs/roachprod.log; ps axeww -o pid -o command >> ${HOME}/logs/roachprod.log; [ -x /usr/bin/lslocks ] && /usr/bin/lslocks >> ${HOME}/logs/roachprod.log;  export ROACHPROD=1 && GOTRACEBACK=crash COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING=1 COCKROACH_DEV_LICENSE=crl-0-EJL04ukFGAEiI0NvY2tyb2FjaCBMYWJzIC0gUHJvZHVjdGlvbiBUZXN0aW5n COCKROACH_BINARY=/home/agent/work/.go/src/github.com/cockroachdb/cockroach/cockroach.linux-2.6.32-gnu-amd64 COCKROACH_ENABLE_RPC_COMPRESSION=false ./cockroach start-single-node --insecure --store=path=/mnt/data1/cockroach --log-dir=${HOME}/logs --background --cache=25% --max-sql-memory=25% --port=26257 --http-port=26258 --locality=cloud=gce,region=us-central1,zone=us-central1-b --join=35.239.190.152:26257 --advertise-host=$(hostname -I | awk '{print $1}') >> ${HOME}/logs/cockroach.stdout.log 2>> ${HOME}/logs/cockroach.stderr.log || (x=$?; cat ${HOME}/logs/cockroach.stderr.log; exit $x): exit status 1
		  | (1) attached stack trace
		  |   | github.com/cockroachdb/cockroach/pkg/cmd/roachprod/install.Cockroach.Start.func2
		  |   | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/install/cockroach.go:296
		  |   | github.com/cockroachdb/cockroach/pkg/cmd/roachprod/install.(*SyncedCluster).Parallel.func1.1
		  |   | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/install/cluster_synced.go:1644
		  |   | runtime.goexit
		  |   | 	/usr/local/go/src/runtime/asm_amd64.s:1373
		  | Wraps: (2) 3 safe details enclosed
		  | Wraps: (3) ~ ulimit -c unlimited; mkdir -p ${HOME}/logs; echo ">>> roachprod start: $(date)" >> ${HOME}/logs/roachprod.log; ps axeww -o pid -o command >> ${HOME}/logs/roachprod.log; [ -x /usr/bin/lslocks ] && /usr/bin/lslocks >> ${HOME}/logs/roachprod.log;  export ROACHPROD=1 && GOTRACEBACK=crash COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING=1 COCKROACH_DEV_LICENSE=crl-0-EJL04ukFGAEiI0NvY2tyb2FjaCBMYWJzIC0gUHJvZHVjdGlvbiBUZXN0aW5n COCKROACH_BINARY=/home/agent/work/.go/src/github.com/cockroachdb/cockroach/cockroach.linux-2.6.32-gnu-amd64 COCKROACH_ENABLE_RPC_COMPRESSION=false ./cockroach start-single-node --insecure --store=path=/mnt/data1/cockroach --log-dir=${HOME}/logs --background --cache=25% --max-sql-memory=25% --port=26257 --http-port=26258 --locality=cloud=gce,region=us-central1,zone=us-central1-b --join=35.239.190.152:26257 --advertise-host=$(hostname -I | awk '{print $1}') >> ${HOME}/logs/cockroach.stdout.log 2>> ${HOME}/logs/cockroach.stderr.log || (x=$?; cat ${HOME}/logs/cockroach.stderr.log; exit $x)
		  |   | E200717 18:31:07.516765 1 cli/error.go:375  ERROR: cannot use --join with 'cockroach start-single-node' -- use 'cockroach start' instead
		  |   | ERROR: cannot use --join with 'cockroach start-single-node' -- use 'cockroach start' instead
		  |   | Failed running "start-single-node"
		  | Wraps: (4) exit status 1
		  | Error types: (1) *withstack.withStack (2) *safedetails.withSafeDetails (3) *errutil.withMessage (4) *exec.ExitError: 
		  | I200717 18:31:07.541844 1 cluster_synced.go:1726  command failed
		Wraps: (2) exit status 1
		Error types: (1) *main.withCommandDetails (2) *exec.ExitError
More

Artifacts: /activerecord
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues

craig bot pushed a commit that referenced this issue Jul 17, 2020
@ekalinin @otan @irfansharif
Merge #51374 #51484 #51557 #51558
7cb22cd 
51374: sql: add a virtual index on the pg_catalog.pg_type.OID r=rohany a=ekalinin

Fixes #49208

Release note (performance improvement): scans over virtual
table pg_type by OID column have improved performance in common cases.

51484: geomfn: implement validity operators r=rytaft a=otan

Unfortunately we cannot implement ST_IsValidDetail because it returns a
composite type, which we do not yet support.

Resolves #48960
Resolves #48961
Resolves #48963
Resolves #48964

Release note (sql change): Implements ST_IsValid, ST_IsValidReason and
ST_MakeValid operators for geometry types.

51557: roachprod: fix roachprod start behaviour for single node clusters r=rafiss a=irfansharif

Fixes #51532.

This is fallout from #51329, after which we tried using --join flags for
single node clusters (that roachprod uses `start-single-node` for). This
tripped up roachtests like #51532, which are now fixed.

Release note: None.

51558: roachtest: cleanup sqlalchemy roachtest r=rafiss a=irfansharif

Was just in the area investigating something else, cleaned it up a bit.
It's just all code movement.

Release note: None

Co-authored-by: kev <[email protected]>
Co-authored-by: Oliver Tan <[email protected]>
Co-authored-by: irfan sharif <[email protected]>
@craig craig bot closed this as completed in 8a90d3c Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Milestone
20.2
Development

Successfully merging a pull request may close this issue.

roachprod: fix roachprod start behaviour for single node clusters irfansharif/cockroach
2 participants
@rafiss @cockroach-teamcity