-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: parse followed by format is not idempotent for EXPLAIN ANALYZE (PLAN) #51473
Comments
|
@rohany can you clarify exactly what RSG is doing? Is it actually using the |
Yeah, it looks like it is generating a statement, parsing it, then dumping it with |
I think that won't work in general, various statements have multiple forms that get normalized. My guess is that it's generating a statement, parsing it, dumping it, then parsing it again, then dumping it again, and cross-checking the two dumps. |
The relevant code is in |
51477: sql: be more strict with validating EXPLAIN r=RaduBerinde a=RaduBerinde #### sql: be more strict with validating EXPLAIN Verify during paring that we are not specifying an invalid mode for `EXPLAIN ANALYZE`. Fixes #51473. Release note: None Co-authored-by: Radu Berinde <[email protected]>
Verify during paring that we are not specifying an invalid mode for `EXPLAIN ANALYZE`. Fixes cockroachdb#51473. Release note: None
found by the RSG tests:
Parse followed by Format is not idempotent: "EXPLAIN ANALYZE ( PLAN ) ALTER SEQUENCE HOUR RENAME TO FAMILY . LEAST . GREATEST" -> "EXPLAIN ANALYZE ALTER SEQUENCE hour RENAME TO "family".least.greatest" != "EXPLAIN ANALYZE (DISTSQL) ALTER SEQUENCE hour RENAME TO "family".least.greatest"
The text was updated successfully, but these errors were encountered: