kv: TestStoreRangeMergeConcurrentRequests failed due to "SuggestedRange not different from original desc" #50795
Assignees
Labels
A-kv-server
Relating to the KV-level RPC server
C-test-failure
Broken test (automatically or manually discovered).
Comments
|
Hi @rytaft, please add a C-ategory label to your issue. Check out the label system docs. While you're here, please consider adding an A- label to help keep our repository tidy. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
rytaft
added
A-kv-server
rytaft
added a commit
to rytaft/cockroach
that referenced
this issue
Jun 30, 2020
This commit skips 4 tests as part of the test-infra-team flaky test cleanup: TestGossipHandlesReplacedNode TestStoreRangeMergeConcurrentRequests TestCheckConsistencyInconsistent TestRepartitioning Informs cockroachdb#50024 Informs cockroachdb#50795 Informs cockroachdb#50830 Informs cockroachdb#49112 Release note: None
craig bot
pushed a commit
that referenced
this issue
Jun 30, 2020
50768: colexec: use Get methods on native type slices r=jordanlewis a=jordanlewis Also, add //gcassert:inline assertions on all Get methods but the DatumVec ones and the gcassert linter, to prove that all of these Get methods are inlined. Here are some benchmarks. I didn't run them all, because I believe that the guaranteed inlining proven by gcassert implies that any benchmark differences must be due to "binary layout" or other ghosts. ``` Distinct/Ordered/hasNulls=false/newTupleProbability=0.010/rows=65536/cols=2/ordCols=2-24 468µs ± 0% 462µs ± 0% -1.26% (p=0.000 n=10+10) name old speed new speed delta Distinct/Ordered/hasNulls=false/newTupleProbability=0.010/rows=65536/cols=2/ordCols=2-24 2.24GB/s ± 0% 2.27GB/s ± 0% +1.28% (p=0.000 n=10+10) CastOp/useSel=true/hasNulls=true/int_to_float-24 5.18µs ± 2% 4.60µs ± 1% -11.21% (p=0.000 n=9+9) CastOp/useSel=true/hasNulls=false/int_to_float-24 1.06µs ± 7% 1.03µs ± 5% ~ (p=0.101 n=10+10) CastOp/useSel=false/hasNulls=true/int_to_float-24 5.33µs ± 1% 5.47µs ± 2% +2.53% (p=0.000 n=9+10) CastOp/useSel=false/hasNulls=false/int_to_float-24 1.08µs ± 0% 1.08µs ± 0% ~ (p=0.136 n=10+10) name old speed new speed delta CastOp/useSel=true/hasNulls=true/int_to_float-24 1.58GB/s ± 2% 1.78GB/s ± 1% +12.62% (p=0.000 n=9+9) CastOp/useSel=true/hasNulls=false/int_to_float-24 7.73GB/s ± 7% 7.93GB/s ± 5% ~ (p=0.089 n=10+10) CastOp/useSel=false/hasNulls=true/int_to_float-24 1.54GB/s ± 1% 1.50GB/s ± 2% -2.46% (p=0.000 n=9+10) CastOp/useSel=false/hasNulls=false/int_to_float-24 7.60GB/s ± 0% 7.59GB/s ± 0% ~ (p=0.143 n=10+10) ``` Release note: None 50831: kv/kvserver: Remove buffering from SSTSnapshotStorageFile r=itsbilal a=itsbilal When investigating a durability violation around ingested sstables that disappeared after a power outage, we realized that SSTSnapshotStorageFile does not flush its buffer before doing a Sync(). When used with a pebble SSTWriter, we expect Sync() to ensure all bytes written to that file are synced to disk, which is not what was happening here for the last couple bytes written to the buffer. This change removes buffering from SSTSnapshotStorageFile as pebble's SST writer already does its own buffering. This makes Sync() do what it is expected to do. Release note (bug fix): Fix a bug where a badly timed power outage or system crash could result in an error upon process restart. 50839: partitionccl,kvserver: skip some flaky tests r=rytaft a=rytaft This commit skips 4 tests as part of the test-infra-team flaky test cleanup: TestGossipHandlesReplacedNode TestStoreRangeMergeConcurrentRequests TestCheckConsistencyInconsistent TestRepartitioning Informs #50024 Informs #50795 Informs #50830 Informs #49112 Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Jordan Lewis <[email protected]> Co-authored-by: Bilal Akhtar <[email protected]> Co-authored-by: Rebecca Taft <[email protected]>
craig bot
pushed a commit
that referenced
this issue
Sep 1, 2020
53667: backupccl: fix database resolution for revision_history cluster backups r=dt a=pbardea Previously database descriptor changes were not tracked when performing cluster backups with revision history. Fixes #52392. Release justification: bug fix Release note (bug fix): Database creation/deletion was previously not correctly tracked by revision_history cluster backups. This is now fixed. 53692: sql: fix enums in `pg_catalog.pg_attrdef` r=rohany a=rohany Fixes #53687. This commit ensures that enums are displayed with their logical representation in the catalog table `pg_catalog.pg_attrdef`. Release justification: bug fix Release note: None 53777: kvserver: unskip TestStoreRangeMergeConcurrentRequests r=aayushshah15 a=aayushshah15 I `stressrace`ed it for ~4K runs and couldn't repro. ``` 4456 runs so far, 0 failures, over 28m5s ``` In all likelihood, this test was fixed by @andreimatei's changes around the range descriptor cache. In particular, #51437 and/or #51395. Fixes #50795 Release justification: Non production code change Release note: None Co-authored-by: Paul Bardea <[email protected]> Co-authored-by: Rohan Yadav <[email protected]> Co-authored-by: Aayush Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://teamcity.cockroachdb.com/viewLog.html?buildId=2050046&buildTypeId=Cockroach_UnitTests
The text was updated successfully, but these errors were encountered: