sql: invalid value for parameter "TimeZone": "GMT-08:00" #41776
Labels
A-sql-pgcompat
Semantic compatibility with PostgreSQL
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
good first issue
Comments
rafiss
added
C-enhancement
|
Concrete repro of the issue (this is the same thing as what you're talking about with "parameter", right?): |
|
@jordanlewis I would like to pick this up. I'm new to this. Can you guide me through? |
|
It looks like this error is thrown in Let me know if you have any more questions! |
|
The fix for this particular issue could be pretty simple, but see #36864 for some additional context on a larger change we may want to do later. |
droidnoob
added a commit
to droidnoob/cockroach
that referenced
this issue
Nov 1, 2019
…roachdb#41776 sql: added an extra string to time zone converter to check strings like GMT-08:00 there was no check in place to convert the strings to timezone. Added a regex to check for valid string and convert it to offset in timeutil package Fix for cockroachdb#41776 Release Notes: * SQL - Now Accepts timezone="GMT-08:00", UST+11:00, -03:00 Release note (<category, see below>): <what> <show> <why>
This was referenced Nov 18, 2019
droidnoob
added a commit
to droidnoob/cockroach
that referenced
this issue
Nov 24, 2019
…roachdb#41776 added an extra checker to time zone converter to check strings like GMT-08:00 there was no check in place to convert the strings to timezone added a regex to check for valid string and convert it to offset in timeutil package Fix for cockroachdb#41776 Release Notes: * SQL - Now Accepts timezone="GMT-08:00", UST+11:00, -03:00. Release note (<category, see below>): <what> <show> <why>
droidnoob
added a commit
to droidnoob/cockroach
that referenced
this issue
Nov 26, 2019
…roachdb#41776 Previously, the inputs like `GMT+5` would cause error. Postgres supports inputs like this. So adding support for these inputs was necessary. sql: Added a check to convert the strings to offset. timeutil: added a function to convert input to offset seconds. Added unit tests. Added a regex to accept the inputs. Release note (sql change): `SET TIME ZONE` now accepts inputs mentioned in cockroachdb#41776. Now accepted time zone strings * `GMT+5` * `UTC-03:59:59`
otan
pushed a commit
to otan-cockroach/cockroach
that referenced
this issue
Nov 26, 2019
…roachdb#41776 Previously, the inputs like `GMT+5` would cause error. Postgres supports inputs like this. So adding support for these inputs was necessary. Release note (sql change): `SET TIME ZONE` now accepts inputs mentioned beginning with 'GMT' and 'UTC', such as 'GMT+5' and 'UTC-3:59'. This was previously unsupported.
droidnoob
added a commit
to droidnoob/cockroach
that referenced
this issue
Nov 27, 2019
…roachdb#41776 Previously, the inputs starting with `UTC` and `GMT` would cause error. Postgres supports inputs like this. So adding support for these inputs was necessary. sql: Added a check to convert the strings to offset. timeutil: added a function to convert input to offset seconds. Added unit tests. Added a regex to accept the above inputs. Cleaned the code. Release note (sql change): `SET TIME ZONE` now accepts inputs beginning with `GMT` and `UTC`, such as `GMT+5` and `UTC-3:59`. This was previously unsupported.
droidnoob
added a commit
to droidnoob/cockroach
that referenced
this issue
Nov 27, 2019
…roachdb#41776 Previously, the inputs starting with `UTC` and `GMT` would cause error. Postgres supports inputs like this. So adding support for these inputs was necessary. sql: Added a check to convert the strings to offset. timeutil: added a function to convert input to offset seconds. Added unit tests. Added a regex to accept the above inputs. Cleaned the code. Release note (sql change): `SET TIME ZONE` now accepts inputs beginning with `GMT` and `UTC`, such as `GMT+5` and `UTC-3:59`. This was previously unsupported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
TimeZoneparameter should supportGMT-08:00as a value, but it doesn't. This is used in a PGJDBC test. See https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/test/java/org/postgresql/test/jdbc2/TimezoneTest.javaThe text was updated successfully, but these errors were encountered: