Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamcity: failed test: TestDefaultColumns #38572

Closed
cockroach-teamcity opened this issue Jun 29, 2019 · 2 comments
Closed

teamcity: failed test: TestDefaultColumns #38572

cockroach-teamcity opened this issue Jun 29, 2019 · 2 comments
Assignees
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone

Comments

@cockroach-teamcity
Copy link
Member

The following tests appear to have failed on master (testrace): TestDefaultColumns

You may want to check for open issues.

#1366551:

TestDefaultColumns
...90629 05:33:06.487062 5359 sql/event_log.go:130  [n1,client=127.0.0.1:58974,user=root,scExec] Event: "finish_schema_change", target: 53, info: {MutationID:108}
I190629 05:33:06.595038 4884 gossip/gossip.go:559  [n1] gossip status (ok, 1 node)
gossip client (0/3 cur/max conns)
gossip server (0/3 cur/max conns, infos 0/0 sent/received, bytes 0B/0B sent/received)
gossip connectivity
  n1 [sentinel];
I190629 05:33:06.598740 4887 server/status/runtime.go:498  [n1] runtime stats: 913 MiB RSS, 186 goroutines, 101 MiB/13 MiB/137 MiB GO alloc/idle/total, 40 MiB/79 MiB CGO alloc/total, 2051.3 CGO/sec, 102.1/9.1 %(u/s)time, 0.2 %gc (3x), 1.4 MiB/1.4 MiB (r/w)net
I190629 05:33:06.599700 5359 sql/sqlbase/structured.go:1148  [n1,client=127.0.0.1:58974,user=root] publish: descID=53 (a) version=326 mtime=2019-06-29 05:33:06.547504959 +0000 UTC
I190629 05:33:06.649610 5359 sql/event_log.go:130  [n1,client=127.0.0.1:58974,user=root] Event: "alter_table", target: 53, info: {TableName:t.public.a Statement:ALTER TABLE t.a ADD COLUMN c109 INT8 User:root MutationID:109 CascadeDroppedViews:[]}
I190629 05:33:06.834280 4852 storage/queue.go:525  [n1,s1,r7/1:/Table/1{1-2}] rate limited in MaybeAdd (merge): context canceled
I190629 05:33:06.941300 5359 sql/sqlbase/structured.go:1148  [n1,client=127.0.0.1:58974,user=root,scExec] publish: descID=53 (a) version=327 mtime=2019-06-29 05:33:06.939731205 +0000 UTC
I190629 05:33:07.057727 5359 sql/lease.go:327  [n1,client=127.0.0.1:58974,user=root,scExec] waiting for 1 leases to expire: desc=[{a 53 326}]
I190629 05:33:07.059803 34652 sql/lease.go:916  new lease: 53("a") ver=327:1561786700.503114169,0, refcount=0
I190629 05:33:07.210441 5359 sql/backfill.go:141  [n1,client=127.0.0.1:58974,user=root,scExec] Running backfill for "a", v=327, m=109
I190629 05:33:07.280692 5359 sql/sqlbase/structured.go:1148  [n1,client=127.0.0.1:58974,user=root,scExec] publish: descID=53 (a) version=328 mtime=2019-06-29 05:33:07.276186881 +0000 UTC
I190629 05:33:07.426294 5359 sql/event_log.go:130  [n1,client=127.0.0.1:58974,user=root,scExec] Event: "finish_schema_change", target: 53, info: {MutationID:109}
I190629 05:33:07.472533 34509 sql/lease.go:916  new lease: 53("a") ver=328:1561786700.504114169,0, refcount=0
I190629 05:33:07.485696 5359 sql/lease.go:327  [n1,client=127.0.0.1:58974,user=root,scExec] waiting for 1 leases to expire: desc=[{a 53 327}]
I190629 05:33:14.662321 4640 util/stop/stopper.go:542  quiescing; tasks left:
1      [async] transport racer
1      [async] storage.IntentResolver: cleanup txn records
1      [async] intent_resolver_ir_batcher
1      [async] intent_resolver_gc_batcher
1      [async] closedts-rangefeed-subscriber
I190629 05:33:14.662948 4640 util/stop/stopper.go:542  quiescing; tasks left:
1      [async] transport racer
1      [async] storage.IntentResolver: cleanup txn records
1      [async] intent_resolver_ir_batcher
1      [async] closedts-rangefeed-subscriber
W190629 05:33:14.663167 35287 storage/intentresolver/intent_resolver.go:816  failed to gc transaction record: could not GC completed transaction anchored at /Table/20/1/53/464374949331632129/0: node unavailable; try another peer
I190629 05:33:14.663347 4640 util/stop/stopper.go:542  quiescing; tasks left:
1      [async] transport racer
1      [async] intent_resolver_ir_batcher
1      [async] closedts-rangefeed-subscriber
I190629 05:33:14.663509 4640 util/stop/stopper.go:542  quiescing; tasks left:
1      [async] transport racer
1      [async] closedts-rangefeed-subscriber
I190629 05:33:14.663627 4897 kv/transport_race.go:108  transport race promotion: ran 162 iterations on up to 18327 requests
I190629 05:33:14.677933 4640 util/stop/stopper.go:542  quiescing; tasks left:
1      [async] closedts-rangefeed-subscriber
    automatic_stats_test.go:433: query 'SELECT count(*) FROM [SHOW STATISTICS FOR TABLE t.a] WHERE statistics_name = 's'': expected:
        101
        
        got:
        41
        




Please assign, take a look and update the issue accordingly.

@cockroach-teamcity cockroach-teamcity added this to the 19.2 milestone Jun 29, 2019
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jun 29, 2019
@rytaft
Copy link
Collaborator

rytaft commented Jul 2, 2019

This is very odd. I cannot reproduce this running either make stress PKG=./pkg/sql/stats/... TESTS='TestDefaultColumns' or make stressrace PKG=./pkg/sql/stats/... TESTS='TestDefaultColumns' for a while. If there is a bug I don't think it's in the stats code, since this function is testing something that should be quite deterministic. Any ideas would be appreciated!

rytaft added a commit to rytaft/cockroach that referenced this issue Sep 24, 2019
This commit adds some logging to the TestDefaultColumns test in order
to help debug a test failure.

Informs cockroachdb#38572

Release note: None
Release justification: category 1, non-production code change
craig bot pushed a commit that referenced this issue Sep 24, 2019
41037: stats: add logging to TestDefaultColumns to help debug flake r=rytaft a=rytaft

This commit adds some logging to the `TestDefaultColumns` test in order
to help debug a test failure.

Informs #38572

Release note: None
Release justification: category 1, non-production code change

41042: tree: fix LIKE suboperator with NULL LHS r=rafiss a=rafiss

If a NULL value was present in the LHS of a suboperator with a LIKE
comparison, then previously the server would crash with a panic. Now it
is handled and there are tests.

closes #40841

Release justification: Low impact bug fix that prevents a server crash.

Release note: None

Co-authored-by: Rebecca Taft <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
@RaduBerinde
Copy link
Member

Since we haven't seen it again in a very long time, let's close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Development

No branches or pull requests

3 participants