Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: Add overloaded TPCC configuration #37047

Closed
bdarnell opened this issue Apr 23, 2019 · 1 comment
Closed

roachtest: Add overloaded TPCC configuration #37047

bdarnell opened this issue Apr 23, 2019 · 1 comment
Assignees
@ajwerner
Labels
A-admission-control C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale

Comments

@bdarnell
Copy link
Contributor

Prior to #37046, the scrub roachtests ran tpcc-1000 on underprovisioned hardware. This discovered some interesting issues like #35986, but also a lot of less-interesting failures like #35985 and #37017. The latter category is mainly OOMs due to our lack of admission control. When we can put better bounds on our memory consumption during overload, we should reintroduce an overloaded test (today that would be TPCC-1000 on a 3-node cluster with 4 vcpus/node) to ensure that we behave reasonably (without crashing, at a minimum).

cc @ajwerner
@ajwerner ajwerner self-assigned this Apr 24, 2019
ajwerner added a commit to ajwerner/cockroach that referenced this issue Apr 25, 2019
@ajwerner
roachtest: add tpcc/overload test
d0909d9 
This PR adds a tpcc roachtest configuration which is sorely overloaded.
We expect that on cluster with 3x 4 vcpu nodes can handle 400 to 600
warehouses on gcp and aws respectively where this test uses 1000.
The test's passing criterion is just that nodes do not crash and that
the test does not fail from the client's perspective.

After landing, the intention is to add this to the nightly suite.

Fixes cockroachdb#37047.

Release note: None
@ajwerner ajwerner mentioned this issue Apr 25, 2019
Closed
ajwerner added a commit to ajwerner/cockroach that referenced this issue Apr 25, 2019
@ajwerner
roachtest: add tpcc/overload test
d8c8114 
This PR adds a tpcc roachtest configuration which is sorely overloaded.
We expect that on cluster with 3x 4 vcpu nodes can handle 400 to 600
warehouses on gcp and aws respectively where this test uses 1000.
The test's passing criterion is just that nodes do not crash and that
the test does not fail from the client's perspective.

After landing, the intention is to add this to the nightly suite.

Fixes cockroachdb#37047.

Release note: None
@awoods187 awoods187 added A-admission-control C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Jun 21, 2019
@github-actions
Copy link

github-actions bot commented Jun 4, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajwerner ajwerner

Labels
A-admission-control C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: add tpcc/overload test ajwerner/cockroach
3 participants
@bdarnell @ajwerner @awoods187