-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goroutinedumper: Compress files #36846
Comments
@giorgosp -- if you're interested in knocking out another issue, this one would be a good follow-up to #36813. Basically in this code cockroach/pkg/server/goroutinedumper/goroutinedumper.go Lines 177 to 188 in 4dcde30
we wouldn't pass |
Fixes cockroachdb#36846 Release note: None
Fixes cockroachdb#36846 Release note: None
36922: goroutinedumper: Gzip files r=tbg a=giorgosp Fixes #36846 Release note: None Co-authored-by: George Papadrosou <[email protected]>
Goroutine dumps are large, but compress well. With default settings, the goroutine dumper will fire when there are 1000 goroutines, which produces a file of about 9MB that gzips down to 500KB. We should compress the files we write here (and probably reduce the
total_dump_size_limit
- spending half a gig on this is kind of silly when we only budget 100MB for logs inutil/log
).I'm noticing this because #35986 produces 400MB of goroutine dumps per run (twice the size of its log files), so stressing it keeps filling up my local disk.
The text was updated successfully, but these errors were encountered: