Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: cdc/ledger/rangefeed=false failed #34699

Closed
cockroach-teamcity opened this issue Feb 7, 2019 · 1 comment
Closed

roachtest: cdc/ledger/rangefeed=false failed #34699

cockroach-teamcity opened this issue Feb 7, 2019 · 1 comment
Assignees
@danhhz
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Milestone
19.1

Comments

@cockroach-teamcity
Copy link
Member

SHA: https://github.com/cockroachdb/cockroach/commits/a46a7e275b4406fee6cc919fd935487add0874f0

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
stdbuf -oL -eL \
make stressrace TESTS=cdc/ledger/rangefeed=false PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1128052&tab=buildLog

The test failed on release-2.1:
	test.go:743,cdc.go:80,cdc.go:452: pq: unknown cluster setting 'changefeed.push.enabled'
@cockroach-teamcity cockroach-teamcity added this to the 2.2 milestone Feb 7, 2019
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. labels Feb 7, 2019
@cockroach-teamcity
Copy link
Member Author

SHA: https://github.com/cockroachdb/cockroach/commits/e4127466ae0a44efb624afcaf0861903028b6e18

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
stdbuf -oL -eL \
make stressrace TESTS=cdc/ledger/rangefeed=false PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1129825&tab=buildLog

The test failed on release-2.1:
	cdc.go:80,cdc.go:452,test.go:1206: pq: unknown cluster setting 'changefeed.push.enabled'

@danhhz danhhz self-assigned this Feb 11, 2019
danhhz added a commit to danhhz/cockroach that referenced this issue Feb 11, 2019
@danhhz
roachtest: fix cdc/*/rangefeed=false
051fb45 
The `changefeed.push.enabled` setting doesn't exist on release-2.1, so
don't try setting it.

Closes cockroachdb#34698
Closes cockroachdb#34699
Closes cockroachdb#34697
Closes cockroachdb#34696
Closes cockroachdb#34389

Release note: None
@danhhz danhhz mentioned this issue Feb 11, 2019
Merged
craig bot pushed a commit that referenced this issue Feb 11, 2019
@danhhz
Merge #34787
235c81c 
34787: roachtest: fix cdc/*/rangefeed=false r=nvanbenschoten,tbg a=danhhz

The `changefeed.push.enabled` setting doesn't exist on release-2.1, so
don't try setting it.

Closes #34698
Closes #34699
Closes #34697
Closes #34696
Closes #34389

Release note: None

Co-authored-by: Daniel Harrison <[email protected]>
@craig craig bot closed this as completed in #34787 Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danhhz danhhz

Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Projects
None yet
Milestone
19.1
Development

No branches or pull requests
2 participants
@danhhz @cockroach-teamcity