Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: bump grpc log level from WARNING to ERROR #34165

Closed
tbg opened this issue Jan 22, 2019 · 1 comment
Closed

cli: bump grpc log level from WARNING to ERROR #34165

tbg opened this issue Jan 22, 2019 · 1 comment
Labels
A-kv-server Relating to the KV-level RPC server A-logging In and around the logging infrastructure. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-server-and-security DB Server & Security
Milestone
19.1

Comments

@tbg
Copy link
Member

tbg commented Jan 22, 2019 •
edited by cockroach-jira-scripts
Loading

gRPC is too verbose. We can "fix" that by changing this line:

cockroach/pkg/cli/start.go

Line 447 in d591a49

grpcutil.SetSeverity(log.Severity_WARNING)

It's unclear whether we'd be losing anything, though. I tend to think not because the final connection errors are always bubbled up to the dialer. See for example

#34155 (comment)

Jira issue: CRDB-4666
@tbg tbg added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jan 22, 2019
@tbg tbg added this to the 2.2 milestone Jan 22, 2019
@tbg tbg self-assigned this Jan 22, 2019
@knz knz added A-kv-server Relating to the KV-level RPC server A-logging In and around the logging infrastructure. labels Apr 1, 2021
@jlinder jlinder added the T-server-and-security DB Server & Security label Jun 16, 2021
@tbg tbg removed their assignment May 31, 2022
@tbg
Copy link
Member Author

tbg commented Jul 17, 2023

Done in #99191

@tbg tbg closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-kv-server Relating to the KV-level RPC server A-logging In and around the logging infrastructure. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-server-and-security DB Server & Security
Projects
None yet
Milestone
19.1
Development

No branches or pull requests
3 participants
@jlinder @knz @tbg