Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered Key Encoding for float64 keys #31

Closed
andybons opened this issue Jul 24, 2014 · 0 comments · Fixed by #365
Closed

Ordered Key Encoding for float64 keys #31

andybons opened this issue Jul 24, 2014 · 0 comments · Fixed by #365

Comments

@andybons
Copy link
Contributor

Based on http://sqlite.org/src4/doc/trunk/www/key_encoding.wiki

@andybons andybons self-assigned this Jul 24, 2014
andybons added a commit that referenced this issue Aug 4, 2014
Summary:
This is the baseline on how I will approach tests for the other encodings (random set of values sorted and checked).

Moves toward a fix for #31

Test Plan: unit tests

Reviewers: spencerkimball, petermattis

Subscribers: team

Differential Revision: http://phabricator.cockroachdb.org/D122
andybons added a commit that referenced this issue Aug 4, 2014
Summary:
This is the baseline on how I will approach tests for the other encodings (random set of values sorted and checked).

Moves toward a fix for #31

Test Plan: unit tests

Reviewers: petermattis, spencerkimball

Reviewed By: spencerkimball

Subscribers: team

Differential Revision: http://phabricator.cockroachdb.org/D122
andybons added a commit that referenced this issue Aug 5, 2014
Summary: small change involving #31

Test Plan: unit tests

Reviewers: spencerkimball, joyt, petermattis

Reviewed By: petermattis

Subscribers: team

Differential Revision: http://phabricator.cockroachdb.org/D132
andybons added a commit that referenced this issue Aug 5, 2014
Summary:
all that's left is working out the float precision issues and testing ordering for those as well.

towards a fix for #31

Test Plan: unit tests

Reviewers: petermattis, spencerkimball

Reviewed By: petermattis, spencerkimball

Subscribers: team

Differential Revision: http://phabricator.cockroachdb.org/D133
@andybons andybons changed the title Ordered Key Encoding Ordered Key Encoding for float64 keys Sep 11, 2014
@andybons andybons removed their assignment Feb 24, 2015
petermattis added a commit that referenced this issue Mar 3, 2015
Add DecodeFloat and flesh out the missing decodeSmallNumber.

Handling floating point precision is difficult so these routines
leverage the standard library floating point parsing and formatting.

Fixes #31
soniabhishek pushed a commit to soniabhishek/cockroach that referenced this issue Feb 15, 2017
soniabhishek pushed a commit to soniabhishek/cockroach that referenced this issue Feb 15, 2017
pav-kv pushed a commit to pav-kv/cockroach that referenced this issue Mar 5, 2024
…ation

raft: fix panic on MsgApp after log truncation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant