-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: Pretty Printing of Tuples does not match postgres #25522
Labels
A-sql-pgcompat
Semantic compatibility with PostgreSQL
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
@justinj I was told you fixed arrays for a similar issue. |
See the |
This was referenced Aug 1, 2018
craig bot
pushed a commit
that referenced
this issue
Aug 1, 2018
28128: sql: casting to timestamp should strip tz info r=jordanlewis a=jordanlewis And binary operations between timestamp and timestamptz should strip the tz from the timestamptz. Confirmed that all of this behavior matches postgres (and that it didn't before). Release note (bug fix): correct casts and binary operators between timestamptz and timestamp in some cases. 28149: sql: avoid using Tuple in RangePartition r=knz a=knz Forked off #28143, needed for #25522 / #26624. The `Tuple` AST node is really for scalar tuples. RangePartition is not using a scalar tuple. So split them. Release note: None Co-authored-by: Jordan Lewis <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
craig bot
pushed a commit
that referenced
this issue
Aug 2, 2018
28151: sql: fix the pg text representation of tuples/arrays r=knz a=knz Forked off #28143. Fixes #25522. This patch fixes the conversion of arrays and tuples to text for the purpose of emitting the arrays/tuples back to a client through pgwire. This now properly supports nested arrays, arrays containing tuples, tuples containing arrays, etc. Labels in tuples are never emitted through pgwire. Release note (bug fix): CockroachDB supports a wider range of tuple and array values in query results. Co-authored-by: Raphael 'kena' Poss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-sql-pgcompat
Semantic compatibility with PostgreSQL
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
We do not pretty print tuples the same way that postgres does.
Postgres:
Cockroach:
The text was updated successfully, but these errors were encountered: