Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: typo in node map onboarding screen #25096

Closed
nstewart opened this issue Apr 26, 2018 · 1 comment · Fixed by #25112
Closed

ui: typo in node map onboarding screen #25096

nstewart opened this issue Apr 26, 2018 · 1 comment · Fixed by #25112
Assignees
@vilterp
Labels
A-webui-nodemap C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Milestone
2.0.x

Comments

@nstewart
Copy link
Contributor

image

Step 3: Refer this configuration guide to configure the Node Map.

Missing 'to'. Should be

Refer to this guide to configure the roadmap
@nstewart nstewart added the A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. label Apr 26, 2018
@couchand couchand added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-webui-nodemap backport-2.0.x and removed A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. labels Apr 26, 2018
@couchand couchand changed the title Typo in map onboarding screen CockroachDB v2.0.0 ui: typo in node map onboarding screen Apr 26, 2018
@couchand couchand added this to the 2.0.x milestone Apr 26, 2018
@vilterp vilterp self-assigned this Apr 26, 2018
@vilterp
Copy link
Contributor

vilterp commented Apr 26, 2018

My bad 🤦

@vilterp vilterp mentioned this issue Apr 26, 2018
Merged
vilterp pushed a commit to vilterp/cockroach that referenced this issue Apr 26, 2018
ui: fix typo in node map onboarding screen
290a400 
Fixes cockroachdb#25096

Release note (admin ui change): fix typo in node map onboarding screen
@vilterp vilterp mentioned this issue Apr 26, 2018
Closed
vilterp pushed a commit to vilterp/cockroach that referenced this issue Jul 2, 2018
ui: fix typo in node map onboarding screen
da3f68c 
Fixes cockroachdb#25096

Release note (admin ui change): fix typo in node map onboarding screen
craig bot pushed a commit that referenced this issue Jul 3, 2018
Merge #25112
c071d5a 
25112: ui: fix typo in node map onboarding screen r=vilterp a=vilterp

Fixes #25096

Before;
![image](https://user-images.githubusercontent.com/7341/39328525-9e1b070c-4969-11e8-9a94-c8da59cd0069.png)

After:
![image](https://user-images.githubusercontent.com/7341/39328511-94bb181e-4969-11e8-99ea-2d7b74dd0670.png)

Release note (admin ui change): fix typo in node map onboarding screen

Co-authored-by: Pete Vilter <[email protected]>
@vilterp vilterp mentioned this issue Jul 3, 2018
Merged
@craig craig bot closed this as completed in #25112 Jul 3, 2018
vilterp pushed a commit to vilterp/cockroach that referenced this issue Jul 3, 2018
ui: fix typo in node map onboarding screen
adc98f3 
Fixes cockroachdb#25096

Release note (admin ui change): fix typo in node map onboarding screen
craig bot pushed a commit that referenced this issue Jul 3, 2018
@tbg
Merge #27129
c9abd99 
27129: backport-2.0: ui: fix typo in node map onboarding screen r=benesch a=vilterp

Backport of #25112

Fixes #25096

Release note (admin ui change): fix typo in node map onboarding screen

Co-authored-by: Tobias Schottdorf <[email protected]>
Co-authored-by: Pete Vilter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vilterp vilterp

Labels
A-webui-nodemap C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
2.0.x
Development

Successfully merging a pull request may close this issue.

ui: fix typo in node map onboarding screen vilterp/cockroach
3 participants
@vilterp @couchand @nstewart