Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stopper: spammy log message about throttling async task #24512

Closed
petermattis opened this issue Apr 5, 2018 · 1 comment
Closed

stopper: spammy log message about throttling async task #24512

petermattis opened this issue Apr 5, 2018 · 1 comment
Assignees
@petermattis
Milestone
2.0.x

Comments

@petermattis
Copy link
Collaborator

Run a local cluster and open the Admin UI and navigate to one of the dashboards. Fairly quickly you'll see a lot of log spam that looks like:

I180405 16:20:30.549882 1974 util/stop/stopper.go:291  [n1,ts-srv] stopper throttling task from ts.Server: query due to semaphore

By default, ts uses 8 worker threads, but the admin UI graph dashboards often have many more requests.

We should either remove this spammy log message or adding a flag to RunAsyncTask to silence it in this use case.

@bdarnell, @spencerkimball Thoughts?
@petermattis petermattis added this to the 2.0.x milestone Apr 5, 2018
@petermattis petermattis self-assigned this Apr 5, 2018
@bdarnell
Copy link
Contributor

bdarnell commented Apr 5, 2018

That message isn't valuable; we should just downgrade it to log.Eventf.

@petermattis petermattis mentioned this issue Apr 5, 2018
Merged
petermattis added a commit to petermattis/cockroach that referenced this issue Apr 5, 2018
@petermattis
stopper: downgrade a spammy log message to a log event
073bb37 
Downgrade a log message about "throttling async task" to a log
event. This occurs easily for the timeseries usage of `RunLimitedAsync`
task.

Fixes cockroachdb#24512

Release note: None
craig bot added a commit that referenced this issue Apr 5, 2018
@craig
Merge #24516
c0191d4 
24516: stopper: downgrade a spammy log message to a log event r=bdarnell a=petermattis

Downgrade a log message about "throttling async task" to a log
event. This occurs easily for the timeseries usage of `RunLimitedAsync`
task.

Fixes #24512

Release note: None
@craig craig bot closed this as completed in #24516 Apr 5, 2018
@andreimatei andreimatei mentioned this issue Apr 5, 2018
Closed
petermattis added a commit to petermattis/cockroach that referenced this issue Apr 5, 2018
@petermattis
stopper: downgrade a spammy log message to a log event
0703ec8 
Downgrade a log message about "throttling async task" to a log
event. This occurs easily for the timeseries usage of `RunLimitedAsync`
task.

Fixes cockroachdb#24512

Release note: None
@petermattis petermattis mentioned this issue Apr 5, 2018
Merged
craig bot added a commit that referenced this issue Apr 5, 2018
@craig
Merge #24522
837f807 
24522: backport-2.0: stopper: downgrade a spammy log message to a log event r=bdarnell a=petermattis

Backport 1/1 commits from #24516.

/cc @cockroachdb/release

---

Downgrade a log message about "throttling async task" to a log
event. This occurs easily for the timeseries usage of `RunLimitedAsync`
task.

Fixes #24512

Release note: None
@a-robinson a-robinson mentioned this issue Apr 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermattis petermattis

Labels
None yet
Projects
None yet
Milestone
2.0.x
Development

No branches or pull requests
2 participants
@bdarnell @petermattis