Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.0-beta.20180305: NPE in ts/query.go #23766

Closed
tbg opened this issue Mar 13, 2018 · 0 comments
Closed

v2.0-beta.20180305: NPE in ts/query.go #23766

tbg opened this issue Mar 13, 2018 · 0 comments
Assignees
@mrtracy
Milestone
2.0

Comments

@tbg
Copy link
Member

tbg commented Mar 13, 2018

https://sentry.io/cockroach-labs/cockroachdb/issues/490486096/

*log.safeError: stopper.go:178: runtime.errorString: runtime error: invalid memory address or nil pointer dereference
  File "github.com/cockroachdb/cockroach/pkg/ts/query.go", line 757, in func1
  File "github.com/cockroachdb/cockroach/pkg/ts/query.go", line 1069, in Query
  File "github.com/cockroachdb/cockroach/pkg/ts/query.go", line 840, in QueryMemoryConstrained
  File "github.com/cockroachdb/cockroach/pkg/ts/server.go", line 234, in 1
  File "github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go", line 327, in func1
...
(4 additional frame(s) were not displayed)

stopper.go:178: runtime.errorString: runtime error: invalid memory address or nil pointer dereference
@tbg tbg added this to the 2.0 milestone Mar 13, 2018
@jordanlewis jordanlewis mentioned this issue Mar 13, 2018
Merged
mrtracy pushed a commit to mrtracy/cockroach that referenced this issue Mar 13, 2018
ts: Fix nil pointer panic on invalid TS query
0ec041d 
A query which specified an invalid enumeration value for
SourceAggregator would cause a nil pointer panic on the server.
Repaired this fix and added a test for invalid values of all the
enumeration values of the query request.

Fixes cockroachdb#23766

Release note: None
@mrtracy mrtracy mentioned this issue Mar 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrtracy mrtracy

Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@tbg @mrtracy