Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: make per-node views actually per-node #18452

Closed
dianasaur323 opened this issue Sep 12, 2017 · 5 comments
Closed

ui: make per-node views actually per-node #18452

dianasaur323 opened this issue Sep 12, 2017 · 5 comments
Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale

Comments

@dianasaur323
Copy link
Contributor

On the per node view in the admin UI, we are showing node list. This is confusing from an information architecture perspective, since that is a cluster-wide metric.

image

@dianasaur323 dianasaur323 added this to the 1.2 milestone Sep 12, 2017
@a-robinson
Copy link
Contributor

a-robinson commented Sep 12, 2017

This actually has a use, though. Each node has its own view of how many live nodes there are in the cluster at a time. If a node is far behind or partitioned away from the others, its reported node count will be different from the count reported by the other nodes.

We'd probably be better off calling the graph "Live Node Count" rather than just "Node Count", but I don't think we want to change what it shows.

@dianasaur323
Copy link
Contributor Author

Ok, that makes sense, although it begs the question of if having this as a time series graph is really the right approach. It makes me think that we should have a view that shows what each node currently sees as cluster state. We are unlikely to have time to do this in 1.2, so I think your approach of calling it that, and perhaps adding a tooltip of why it matters would be an appropriate first step.

@dianasaur323 dianasaur323 self-assigned this Sep 15, 2017
a-robinson added a commit to a-robinson/cockroach that referenced this issue Sep 15, 2017
a-robinson added a commit to a-robinson/cockroach that referenced this issue Sep 15, 2017
a-robinson added a commit to a-robinson/cockroach that referenced this issue Sep 15, 2017
@couchand
Copy link
Contributor

This naturally rolls into some bigger IA questions. Notably, some charts show aggregates for the cluster as a whole and other show a breakdown by node. Some charts (such as latency) have several different percentile charts, where having a single chart showing multiple percentiles would be more valuable.

@dianasaur323
Copy link
Contributor Author

haha, don't open the can of worms @couchand! jk, but yes agree that we should approach this problem holistically when we get to it.

@dianasaur323 dianasaur323 modified the milestones: 1.2, 1.3 Sep 22, 2017
@couchand couchand added A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Apr 24, 2018
@knz knz assigned piyush-singh and unassigned dianasaur323 May 9, 2018
@couchand couchand assigned couchand and unassigned piyush-singh Sep 18, 2018
@petermattis petermattis removed this from the 2.1 milestone Oct 5, 2018
@github-actions
Copy link

github-actions bot commented Jun 9, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale
Projects
None yet
Development

No branches or pull requests

5 participants