Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: add de / re commissioning nodes to event log #17677

Closed
dianasaur323 opened this issue Aug 16, 2017 · 5 comments · Fixed by #18178
Closed

ui: add de / re commissioning nodes to event log #17677

dianasaur323 opened this issue Aug 16, 2017 · 5 comments · Fixed by #18178
Assignees
@benesch
Milestone
1.1

Comments

@dianasaur323
Copy link
Contributor

dianasaur323 commented Aug 16, 2017 •
edited
Loading

We want to surface important events in the event log - we currently include node joins, and should also include de / re commissioning events.

This is the final outstanding item in #6198 (comment).
@dianasaur323 dianasaur323 added this to the 1.1 milestone Aug 16, 2017
@cuongdo
Copy link
Contributor

cuongdo commented Aug 30, 2017

@benesch Are you going to get to this by 1.1?

@tbg tbg mentioned this issue Aug 31, 2017
Closed
@benesch
Copy link
Contributor

benesch commented Sep 1, 2017

Welp, seems unlikely.

@a-robinson
Copy link
Contributor

Adding new event log events is actually fairly easy. I don't think I'll have time today given the investigations I'm in the middle of, but if we'd be open to cherrypicking it Monday or Tuesday we could probably get it in. Just depends on how important it is.

@dianasaur323
Copy link
Contributor Author

I'm not sure this will be important enough to cherry pick into the release branch... Perhaps we should just punt to 1.2.

@benesch
Copy link
Contributor

benesch commented Sep 1, 2017

Turns out I have a half-finished branch. Trying to finish this up right now.

@benesch benesch mentioned this issue Sep 2, 2017
Merged
benesch added a commit to benesch/cockroach that referenced this issue Sep 2, 2017
@benesch
server,storage,sql: record node {de,re}commissioning in the event log
0d72faa 
Fixes cockroachdb#17677.
benesch added a commit to benesch/cockroach that referenced this issue Sep 5, 2017
@benesch
server,storage,sql: record node {de,re}commissioning in the event log
2da77e9 
Fixes cockroachdb#17677.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesch benesch

Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

server,storage,sql: record node {de,re}commissioning in the event log benesch/cockroach
4 participants
@benesch @cuongdo @dianasaur323 @a-robinson