Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: make cluster setting "server.remote_debugging.mode" into an enum setting #15602

Closed
rjnn opened this issue May 2, 2017 · 0 comments
Closed

server: make cluster setting "server.remote_debugging.mode" into an enum setting #15602

rjnn opened this issue May 2, 2017 · 0 comments
Assignees
@rjnn
Labels
S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.
Milestone
1.1

Comments

@rjnn
Copy link
Contributor

rjnn commented May 2, 2017

Now that we have enum settings in #15307, this setting should be an enum setting, as it currently fails silently if the value is not one of "any", "true", "t", or "1".
@rjnn rjnn added the S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. label May 2, 2017
@rjnn rjnn added this to the 1.1 milestone May 2, 2017
@rjnn rjnn self-assigned this May 2, 2017
petermattis added a commit to petermattis/cockroach that referenced this issue May 3, 2017
@petermattis
server: use an EnumSetting for server.remote_debugging.mode
91f8f2f 
Fixes cockroachdb#15602
@petermattis petermattis mentioned this issue May 3, 2017
Merged
petermattis added a commit to petermattis/cockroach that referenced this issue May 4, 2017
@petermattis
server: use a validation function for server.remote_debugging.mode
5708b72 
Fixes cockroachdb#15602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjnn rjnn

Labels
S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@rjnn @petermattis