sql/tests: TestRandomSyntaxFunctions failed [malformed key sentinel byte: bc02c4] #128757
Assignees
Labels
A-storage
Relating to our storage engine (Pebble) on-disk storage.
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
T-storage
Storage Team
Comments
cockroach-teamcity
added
branch-master
rafiss
changed the title
|
Requesting help from Storage to interpret this panic: |
rafiss
added
T-storage
blathers-crl
bot
added
the
A-storage
itsbilal
moved this from Incoming
to Tests (failures, skipped, flakes)
in [Deprecated] Storage
|
@rafiss do you know: does this test produce random byte slices for the arguments? I think I just need to update the |
|
Thanks for explaining; makes sense. Yeah, it makes random bytes here: cockroach/pkg/sql/tests/rsg_test.go Line 448 in f519569 Another option would be to exclude |
rafiss
removed
the
release-blocker
jbowens
added a commit
to jbowens/cockroach
that referenced
this issue
Aug 13, 2024
Ensure that the user-provided engine keys are valid before using them to seek, in storage's SQL builtins. The Comparer will now panic if there's an attempt to compare using an invalid key. We want to continue to accept these keys as engine keys (rather than encoding them within the builtin), because we may want to pass local keyspans. Epic: none Fix cockroachdb#128757. Release note: none
jbowens
added a commit
to jbowens/cockroach
that referenced
this issue
Aug 14, 2024
Ensure that the user-provided engine keys are valid before using them to seek, in storage's SQL builtins. The Comparer will now panic if there's an attempt to compare using an invalid key. We want to continue to accept these keys as engine keys (rather than encoding them within the builtin), because we may want to pass local keyspans. Epic: none Fix cockroachdb#128757. Release note: none
jbowens
added a commit
to jbowens/cockroach
that referenced
this issue
Aug 14, 2024
Ensure that the user-provided engine keys are valid before using them to seek, in storage's SQL builtins. The Comparer will now panic if there's an attempt to compare using an invalid key. These built-ins now attempt to decode and validate the keys as engine keys. If they validate, it uses them as-is. Otherwise it encodes them as version-less keys. Epic: none Fix cockroachdb#128757. Release note: none
craig bot
pushed a commit
that referenced
this issue
Aug 14, 2024
128935: sql/sem/builtins: validate engine keys in storage builtins r=RaduBerinde a=jbowens Ensure that the user-provided engine keys are valid before using them to seek, in storage's SQL builtins. The Comparer will now panic if there's an attempt to compare using an invalid key. These built-ins now attempt to decode and validate the keys as engine keys. If they validate, it uses them as-is. Otherwise it encodes them as version-less keys. Epic: none Fix #128757. Release note: none 128984: raft: consult StoreLiveness when handling MsgFortify r=nvanbenschoten a=arulajmani Previously, we were always rejecting fortification requests. This patch correctly returns a fortification response by including the leader's supported store liveness epcoh in the MsgFortifyLeaderResp if the follower supports the leader in its StoreLiveness fabric. Closes #125261 Release note: None Co-authored-by: Jackson Owens <[email protected]> Co-authored-by: Arul Ajmani <[email protected]>
github-project-automation
bot
moved this from Tests (failures, skipped, flakes)
to Done
in [Deprecated] Storage
blathers-crl bot
pushed a commit
that referenced
this issue
Sep 18, 2024
Ensure that the user-provided engine keys are valid before using them to seek, in storage's SQL builtins. The Comparer will now panic if there's an attempt to compare using an invalid key. These built-ins now attempt to decode and validate the keys as engine keys. If they validate, it uses them as-is. Otherwise it encodes them as version-less keys. Epic: none Fix #128757. Release note: none
jbowens
added a commit
to jbowens/cockroach
that referenced
this issue
Sep 18, 2024
Ensure that the user-provided engine keys are valid before using them to seek, in storage's SQL builtins. The Comparer will now panic if there's an attempt to compare using an invalid key. These built-ins now attempt to decode and validate the keys as engine keys. If they validate, it uses them as-is. Otherwise it encodes them as version-less keys. Epic: none Fix cockroachdb#128757. Release note: none
RaduBerinde
pushed a commit
to RaduBerinde/cockroach
that referenced
this issue
Oct 1, 2024
Ensure that the user-provided engine keys are valid before using them to seek, in storage's SQL builtins. The Comparer will now panic if there's an attempt to compare using an invalid key. These built-ins now attempt to decode and validate the keys as engine keys. If they validate, it uses them as-is. Otherwise it encodes them as version-less keys. Epic: none Fix cockroachdb#128757. Release note: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sql/tests.TestRandomSyntaxFunctions failed with artifacts on master @ 451cdbe687b3303665bfd490af59c5df777c8909:
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-41183
The text was updated successfully, but these errors were encountered: