Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/catalog/lease: TestParallelLeaseAcquireWithImmediateRelease failed #118521

Closed
cockroach-teamcity opened this issue Jan 31, 2024 · 1 comment · Fixed by #118543
Closed

sql/catalog/lease: TestParallelLeaseAcquireWithImmediateRelease failed #118521

cockroach-teamcity opened this issue Jan 31, 2024 · 1 comment · Fixed by #118543
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-0 Issues/test failures with a fix SLA of 2 weeks T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 31, 2024 •
edited by cockroach-jira-scripts
Loading

sql/catalog/lease.TestParallelLeaseAcquireWithImmediateRelease failed on master @ 03525787deade5395bac0a8b5735fa7e715e22ef:

=== RUN   TestParallelLeaseAcquireWithImmediateRelease
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestParallelLeaseAcquireWithImmediateRelease3111970685
    test_log_scope.go:81: use -show-logs to present logs inline
    test_server_shim.go:294: job 939156697419579393 could not be loaded: failed to get payload for job 939156697419579393: job-info-get: unexpected value: raw_bytes:"\023\352m\005\n3\002" timestamp:<wall_time:1706678278903540197 > 
    panic.go:523: -- test log scope end --
test logs left over in: outputs.zip/logTestParallelLeaseAcquireWithImmediateRelease3111970685
--- FAIL: TestParallelLeaseAcquireWithImmediateRelease (0.91s)

Parameters:

  • attempt=1
  • run=16
  • shard=4
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-35767
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Jan 31, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Jan 31, 2024
This was referenced Jan 31, 2024
Closed
Closed
@rafiss
Copy link
Collaborator

rafiss commented Jan 31, 2024

same error in #118522 and #118523

@exalate-issue-sync exalate-issue-sync bot added P-0 Issues/test failures with a fix SLA of 2 weeks and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Jan 31, 2024
fqazi added a commit to fqazi/cockroach that referenced this issue Jan 31, 2024
@fqazi
catalog/lease: detect if synchronous lease releases are successful
49592b7 
Previously, for unit testing, we added support for synchronously
releasing leases. If the context was cancelled when releasing a lease
synchronously, it was possible for the lease to be erased from memory
and not from storage. As a result, reacquisition could hit an error when
session-based leasing is enabled. To address this, this patch re-orders
operations so that we clear storage first for synchronous lease release,
followed by the in-memory copy.

Fixes: cockroachdb#118522, cockroachdb#118523, cockroachdb#118521

Release note: None
@fqazi fqazi mentioned this issue Jan 31, 2024
Merged
@craig craig bot closed this as completed in #118543 Jan 31, 2024
@craig craig bot closed this as completed in d3c3d4e Jan 31, 2024
wenyihu6 pushed a commit to wenyihu6/cockroach that referenced this issue Feb 21, 2024
@fqazi @wenyihu6
catalog/lease: detect if synchronous lease releases are successful
f5ffa92 
Previously, for unit testing, we added support for synchronously
releasing leases. If the context was cancelled when releasing a lease
synchronously, it was possible for the lease to be erased from memory
and not from storage. As a result, reacquisition could hit an error when
session-based leasing is enabled. To address this, this patch re-orders
operations so that we clear storage first for synchronous lease release,
followed by the in-memory copy.

Fixes: cockroachdb#118522, cockroachdb#118523, cockroachdb#118521

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-0 Issues/test failures with a fix SLA of 2 weeks T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Foundations
Archived in project
Milestone
24.1
Development

Successfully merging a pull request may close this issue.

catalog/lease: detect if synchronous lease releases are successful fqazi/cockroach
2 participants
@rafiss @cockroach-teamcity