Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: SHOW SESSIONS exposes traceID and goroutineID #117625

Closed
dhartunian opened this issue Jan 10, 2024 · 0 comments · Fixed by #118644
Closed

sql: SHOW SESSIONS exposes traceID and goroutineID #117625

dhartunian opened this issue Jan 10, 2024 · 0 comments · Fixed by #118644
Assignees
@maryliag
Labels
A-observability-inf C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@dhartunian
Copy link
Collaborator

dhartunian commented Jan 10, 2024 •
edited by exalate-issue-sync bot
Loading

Is your feature request related to a problem? Please describe.
Exposing the traceID and goroutineID of a session in the SHOW SESSIONS output can aid in investigations to help filter down profile and log output.

Describe the solution you'd like
Output of SHOW SESSIONS should include 2 new columns trace_id and goroutine_id that map to that session's trace and goroutine.

Jira issue: CRDB-35277

Epic CRDB-35278
@dhartunian dhartunian added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability-inf labels Jan 10, 2024
@maryliag maryliag mentioned this issue Jan 19, 2024
Merged
maryliag added a commit to maryliag/cockroach that referenced this issue Jan 22, 2024
@maryliag
sql: add trace_id to show sessions
f94b2c0 
Add the column trace_id to the result of `SHOW SESSIONS`.
Also adding the column to the views:
`crdb_internal.node_sessions` and `crdb_internal.cluster_sessions`.

Part Of cockroachdb#117625

Release note (sql change): Add column `trace_id`
to the response of the `SHOW SESSIONS` command.
maryliag added a commit to maryliag/cockroach that referenced this issue Jan 22, 2024
@maryliag
sql: add trace_id to show sessions
8bbd85e 
Add the column trace_id to the result of `SHOW SESSIONS`.
Also adding the column to the views:
`crdb_internal.node_sessions` and `crdb_internal.cluster_sessions`.

Part Of cockroachdb#117625

Release note (sql change): Add column `trace_id`
to the response of the `SHOW SESSIONS` command.
maryliag added a commit to maryliag/cockroach that referenced this issue Jan 23, 2024
@maryliag
sql: add trace_id to show sessions
43072c2 
Add the column trace_id to the result of `SHOW SESSIONS`.
Also adding the column to the views:
`crdb_internal.node_sessions` and `crdb_internal.cluster_sessions`.

Part Of cockroachdb#117625

Release note (sql change): Add column `trace_id`
to the response of the `SHOW SESSIONS` command.
craig bot pushed a commit that referenced this issue Jan 23, 2024
@maryliag
Merge #118002
5db0b83 
118002: sql: add trace_id to show sessions r=maryliag a=maryliag

Add the column trace_id to the result of `SHOW SESSIONS`.
Also adding the column to the views:
`crdb_internal.node_sessions` and `crdb_internal.cluster_sessions`.

Part Of #117625

Release note (sql change): Add column `trace_id` to the response of the `SHOW SESSIONS` command.

Co-authored-by: maryliag <[email protected]>
@maryliag maryliag mentioned this issue Feb 2, 2024
Merged
craig bot pushed a commit that referenced this issue Feb 6, 2024
@maryliag
Merge #118644
47a68b5 
118644: sql: add goroutine_id to show sessions r=maryliag a=maryliag

Add the column goroutine_id to the result of `SHOW SESSIONS`. Also adding the column to the views:
`crdb_internal.node_sessions` and `crdb_internal.cluster_sessions`.

Fixes #117625

Release note (sql change): Add column `goroutine_id` to the response of the `SHOW SESSIONS` command.

Co-authored-by: maryliag <[email protected]>
@craig craig bot closed this as completed in ec72121 Feb 6, 2024
wenyihu6 pushed a commit to wenyihu6/cockroach that referenced this issue Feb 21, 2024
@maryliag @wenyihu6
sql: add goroutine_id to show sessions
bfd8c83 
Add the column goroutine_id to the result of `SHOW SESSIONS`.
Also adding the column to the views:
`crdb_internal.node_sessions` and `crdb_internal.cluster_sessions`.

Fixes cockroachdb#117625

Release note (sql change): Add column `goroutine_id` to the
response of the `SHOW SESSIONS` command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
A-observability-inf C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add goroutine_id to show sessions maryliag/cockroach
2 participants
@dhartunian @maryliag