Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: import-cancellation failed #116299

Closed
cockroach-teamcity opened this issue Dec 13, 2023 · 1 comment · Fixed by #116300
Closed

roachtest: import-cancellation failed #116299

cockroach-teamcity opened this issue Dec 13, 2023 · 1 comment · Fixed by #116300
Labels
B-coverage-enabled Related to builds that have code coverage enabled. branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 13, 2023 •
edited by cockroach-jira-scripts
Loading

Note: This is a special code-coverage build. If the same failure was hit in a non-coverage run, there should be a similar issue without the B-coverage-enabled label. If there isn't one, it is possible that this failure is related to the code coverage infrastructure or overhead.

roachtest.import-cancellation failed with artifacts on master @ 83bcafa004f79bdb156f6921fb8e898df9925c08:

(test_runner.go:1134).runTest: test timed out (6h0m0s)
test artifacts and logs in: /artifacts/import-cancellation/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=true
  • ROACHTEST_cpu=32
  • ROACHTEST_encrypted=false
  • ROACHTEST_fs=ext4
  • ROACHTEST_localSSD=true
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-34564
@cockroach-teamcity cockroach-teamcity added B-coverage-enabled Related to builds that have code coverage enabled. branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team labels Dec 13, 2023
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Dec 13, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Dec 13, 2023
@yuzefovich
Copy link
Member

We're running the queries more times than we expect, I'll send a patch.

@github-project-automation github-project-automation bot moved this from Triage to Done in SQL Queries Dec 13, 2023
@yuzefovich yuzefovich mentioned this issue Dec 13, 2023
Merged
craig bot pushed a commit that referenced this issue Dec 13, 2023
@yuzefovich @msbutler
Merge #115146 #115674 #116300 #116302
4a10b8f 
115146: importer: support arrays of UDT in some cases r=yuzefovich a=yuzefovich

This commit adjusts the import code to support IMPORT INTO tables with columns typed as arrays of UDTs. This required a couple of minor changes:
- propagating the `SemaCtx` into `ParseDatumStringAs`. Previously, we would always create a fresh one, but now all callers of this method have been adjusted to provide the one they have in scope. This allows us to parse expressions of the form `'Monday'::db.sc.enum_name` where `'Monday'` is a member of an enum.
- implement `importTypeResolver.ResolveType` in the "happy" case. This is used to resolve casts from above to a concrete type.

Note that `ResolveType` implementation is incomplete in the general case. In particular, whenever an import job is created, we _might_ have a set of types available (it appears that this is the case when we're importing into one table - for example, we have logic for importing the whole pgdump, there we can have multiple tables, and set of types won't be available). Whenever we do have a set of types, we can simplify the type resolution to simply match on the name of the type.

However, if we happen to have a table that uses two UDTs with the same name but different schemas, this simplistic resolution won't work, so we still return an error in this case.

Fixes: #112100.

Release note (sql change): CockroachDB now supports IMPORT INTO a table that has columns typed as arrays of user-defined types (like enums). Tables that uses multiple user-defined types with the same name but different schemas are still unsupported.

115674: sql: use background QoS for atomic COPY r=yuzefovich a=yuzefovich

We recently merged a change to make COPY use "background" QoS by default. However, that change was incomplete - it only made it so that we use the "background" QoS only whenever a new txn is started by the copy state machine, and we forgot to make the corresponding update for the initial txn created outside of the state machine, if we're in an implicit txn. This is now fixed.

Note that this initial txn is only used for "atomic" COPY because for non-atomic we always create a fresh txn before each batch.

This commit also adjusts an existing test to verify that the expected QoS is used for all implicit txns.

Epic: None

Release note: None

116300: roachtest: speed up import cancellation r=yuzefovich a=yuzefovich

Previously, when determining the number of TPCH queries we're running during the IMPORT, we used the length of the string, which made it so that we ran queries more than we intended. This is now fixed.

Fixes: #116299.

Epic: None

Release note: None

116302: roachtest: unskip restore/online/tpce/400GB/aws/inc-count=1/nodes=4/cpus=8 r=adityamaru a=msbutler

Epic: none

Release note: none

Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-coverage-enabled Related to builds that have code coverage enabled. branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
24.1
Development

Successfully merging a pull request may close this issue.

roachtest: speed up import cancellation yuzefovich/cockroach
2 participants
@yuzefovich @cockroach-teamcity