Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: v23.1.11: index out of range in quantile.fixMalformed #113680

Closed
cockroach-sentry opened this issue Nov 2, 2023 · 2 comments · Fixed by #113712
Closed

sql: v23.1.11: index out of range in quantile.fixMalformed #113680

cockroach-sentry opened this issue Nov 2, 2023 · 2 comments · Fixed by #113712
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-sentry Originated from an in-the-wild panic report. T-sql-queries SQL Queries Team

Comments

@cockroach-sentry
Copy link
Collaborator

cockroach-sentry commented Nov 2, 2023 •
edited by cockroach-jira-scripts
Loading

This issue was auto filed by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry Link: https://cockroach-labs.sentry.io/issues/4596060865/?referrer=webhooks_plugin

Panic Message:

panic.go:884: runtime error: index out of range [2] with length 2
(1) attached stack trace
  -- stack trace:
  | runtime.gopanic
  | 	GOROOT/src/runtime/panic.go:884
  | runtime.goPanicIndex
  | 	GOROOT/src/runtime/panic.go:113
  | github.com/cockroachdb/cockroach/pkg/sql/stats.quantile.fixMalformed
  | 	github.com/cockroachdb/cockroach/pkg/sql/stats/pkg/sql/stats/quantile.go:811
  | github.com/cockroachdb/cockroach/pkg/sql/stats.predictHistogram
  | 	github.com/cockroachdb/cockroach/pkg/sql/stats/pkg/sql/stats/forecast.go:416
  | github.com/cockroachdb/cockroach/pkg/sql/stats.forecastColumnStatistics
  | 	github.com/cockroachdb/cockroach/pkg/sql/stats/pkg/sql/stats/forecast.go:276
  | github.com/cockroachdb/cockroach/pkg/sql/stats.ForecastTableStatistics
  | 	github.com/cockroachdb/cockroach/pkg/sql/stats/pkg/sql/stats/forecast.go:116
  | github.com/cockroachdb/cockroach/pkg/sql/stats.(*TableStatisticsCache).getTableStatsFromDB
  | 	github.com/cockroachdb/cockroach/pkg/sql/stats/pkg/sql/stats/stats_cache.go:826
  | github.com/cockroachdb/cockroach/pkg/sql/stats.(*TableStatisticsCache).addCacheEntryLocked.func1
  | 	github.com/cockroachdb/cockroach/pkg/sql/stats/pkg/sql/stats/stats_cache.go:386
  | github.com/cockroachdb/cockroach/pkg/sql/stats.(*TableStatisticsCache).addCacheEntryLocked
  | 	github.com/cockroachdb/cockroach/pkg/sql/stats/pkg/sql/stats/stats_cache.go:388
  | github.com/cockroachdb/cockroach/pkg/sql/stats.(*TableStatisticsCache).getTableStatsFromCache
  | 	github.com/cockroachdb/cockroach/pkg/sql/stats/pkg/sql/stats/stats_cache.go:318
  | github.com/cockroachdb/cockroach/pkg/sql/stats.(*TableStatisticsCache).GetTableStats
  | 	github.com/cockroachdb/cockroach/pkg/sql/stats/pkg/sql/stats/stats_cache.go:222
  | github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).createStatsPlan
  | 	github.com/cockroachdb/cockroach/pkg/sql/distsql_plan_stats.go:464
  | github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).createPlanForCreateStats
  | 	github.com/cockroachdb/cockroach/pkg/sql/distsql_plan_stats.go:513
  | github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).planAndRunCreateStats
  | 	github.com/cockroachdb/cockroach/pkg/sql/distsql_plan_stats.go:527
  | github.com/cockroachdb/cockroach/pkg/sql.(*createStatsResumer).Resume.func1
  | 	github.com/cockroachdb/cockroach/pkg/sql/create_stats.go:610
  | github.com/cockroachdb/cockroach/pkg/sql.(*InternalDB).Txn.func1
  | 	github.com/cockroachdb/cockroach/pkg/sql/internal.go:1620
  | github.com/cockroachdb/cockroach/pkg/sql.(*InternalDB).txn.func4
  | 	github.com/cockroachdb/cockroach/pkg/sql/internal.go:1698
  | github.com/cockroachdb/cockroach/pkg/kv.runTxn.func1
  | 	github.com/cockroachdb/cockroach/pkg/kv/db.go:970
  | github.com/cockroachdb/cockroach/pkg/kv.(*Txn).exec
  | 	github.com/cockroachdb/cockroach/pkg/kv/txn.go:928
  | github.com/cockroachdb/cockroach/pkg/kv.runTxn
  | 	github.com/cockroachdb/cockroach/pkg/kv/db.go:969
  | github.com/cockroachdb/cockroach/pkg/kv.(*DB).TxnWithAdmissionControl
  | 	github.com/cockroachdb/cockroach/pkg/kv/db.go:932
  | github.com/cockroachdb/cockroach/pkg/kv.(*DB).Txn
  | 	github.com/cockroachdb/cockroach/pkg/kv/db.go:907
  | github.com/cockroachdb/cockroach/pkg/sql.(*InternalDB).txn
  | 	github.com/cockroachdb/cockroach/pkg/sql/internal.go:1686
  | github.com/cockroachdb/cockroach/pkg/sql.(*InternalDB).Txn
  | 	github.com/cockroachdb/cockroach/pkg/sql/internal.go:1621
  | github.com/cockroachdb/cockroach/pkg/sql.(*createStatsResumer).Resume
  | 	github.com/cockroachdb/cockroach/pkg/sql/create_stats.go:592
  | github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine.func2
  | 	github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1630
  | github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine
  | 	github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1631
  | github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).runJob
  | 	github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:474
  | github.com/cockroachdb/cockroach/pkg/jobs.(*StartableJob).Start.func2
  | 	github.com/cockroachdb/cockroach/pkg/jobs/jobs.go:978
  | github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2
  | 	github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:470
  | runtime.goexit
  | 	GOROOT/src/runtime/asm_amd64.s:1594
Wraps: (2) runtime error: index out of range [2] with length 2
Error types: (1) *withstack.withStack (2) runtime.boundsError
-- report composition:
runtime.boundsError
panic.go:884: *withstack.withStack (top exception)
Stacktrace (expand for inline code snippets):

GOROOT/src/runtime/asm_amd64.s#L1593-L1595
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/util/stop/stopper.go#L469-L471
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/jobs/jobs.go#L977-L979
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/jobs/adopt.go#L473-L475
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/jobs/registry.go#L1630-L1632
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/jobs/registry.go#L1629-L1631
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/create_stats.go#L591-L593
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/internal.go#L1620-L1622
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/internal.go#L1685-L1687
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/kv/db.go#L906-L908
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/kv/db.go#L931-L933
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/kv/db.go#L968-L970
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/kv/txn.go#L927-L929
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/kv/db.go#L969-L971
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/internal.go#L1697-L1699
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/internal.go#L1619-L1621
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/create_stats.go#L609-L611
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/distsql_plan_stats.go#L526-L528
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/distsql_plan_stats.go#L512-L514
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/distsql_plan_stats.go#L463-L465
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/stats/pkg/sql/stats/stats_cache.go#L221-L223
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/stats/pkg/sql/stats/stats_cache.go#L317-L319
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/stats/pkg/sql/stats/stats_cache.go#L387-L389
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/stats/pkg/sql/stats/stats_cache.go#L385-L387
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/stats/pkg/sql/stats/stats_cache.go#L825-L827
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/stats/pkg/sql/stats/forecast.go#L115-L117
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/stats/pkg/sql/stats/forecast.go#L275-L277
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/stats/pkg/sql/stats/forecast.go#L415-L417
https://github.com/cockroachdb/cockroach/blob/fb1ed73d9d88f459c3cda5866fae29831cce06b4/pkg/sql/stats/pkg/sql/stats/quantile.go#L810-L812
GOROOT/src/runtime/panic.go#L112-L114
GOROOT/src/runtime/panic.go#L883-L885

GOROOT/src/runtime/asm_amd64.s in runtime.goexit at line 1594
pkg/util/stop/stopper.go in pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2 at line 470
pkg/jobs/jobs.go in pkg/jobs.(*StartableJob).Start.func2 at line 978
pkg/jobs/adopt.go in pkg/jobs.(*Registry).runJob at line 474
pkg/jobs/registry.go in pkg/jobs.(*Registry).stepThroughStateMachine at line 1631
pkg/jobs/registry.go in pkg/jobs.(*Registry).stepThroughStateMachine.func2 at line 1630
pkg/sql/create_stats.go in pkg/sql.(*createStatsResumer).Resume at line 592
pkg/sql/internal.go in pkg/sql.(*InternalDB).Txn at line 1621
pkg/sql/internal.go in pkg/sql.(*InternalDB).txn at line 1686
pkg/kv/db.go in pkg/kv.(*DB).Txn at line 907
pkg/kv/db.go in pkg/kv.(*DB).TxnWithAdmissionControl at line 932
pkg/kv/db.go in pkg/kv.runTxn at line 969
pkg/kv/txn.go in pkg/kv.(*Txn).exec at line 928
pkg/kv/db.go in pkg/kv.runTxn.func1 at line 970
pkg/sql/internal.go in pkg/sql.(*InternalDB).txn.func4 at line 1698
pkg/sql/internal.go in pkg/sql.(*InternalDB).Txn.func1 at line 1620
pkg/sql/create_stats.go in pkg/sql.(*createStatsResumer).Resume.func1 at line 610
pkg/sql/distsql_plan_stats.go in pkg/sql.(*DistSQLPlanner).planAndRunCreateStats at line 527
pkg/sql/distsql_plan_stats.go in pkg/sql.(*DistSQLPlanner).createPlanForCreateStats at line 513
pkg/sql/distsql_plan_stats.go in pkg/sql.(*DistSQLPlanner).createStatsPlan at line 464
pkg/sql/stats/pkg/sql/stats/stats_cache.go in pkg/sql/stats.(*TableStatisticsCache).GetTableStats at line 222
pkg/sql/stats/pkg/sql/stats/stats_cache.go in pkg/sql/stats.(*TableStatisticsCache).getTableStatsFromCache at line 318
pkg/sql/stats/pkg/sql/stats/stats_cache.go in pkg/sql/stats.(*TableStatisticsCache).addCacheEntryLocked at line 388
pkg/sql/stats/pkg/sql/stats/stats_cache.go in pkg/sql/stats.(*TableStatisticsCache).addCacheEntryLocked.func1 at line 386
pkg/sql/stats/pkg/sql/stats/stats_cache.go in pkg/sql/stats.(*TableStatisticsCache).getTableStatsFromDB at line 826
pkg/sql/stats/pkg/sql/stats/forecast.go in pkg/sql/stats.ForecastTableStatistics at line 116
pkg/sql/stats/pkg/sql/stats/forecast.go in pkg/sql/stats.forecastColumnStatistics at line 276
pkg/sql/stats/pkg/sql/stats/forecast.go in pkg/sql/stats.predictHistogram at line 416
pkg/sql/stats/pkg/sql/stats/quantile.go in pkg/sql/stats.quantile.fixMalformed at line 811
GOROOT/src/runtime/panic.go in runtime.goPanicIndex at line 113
GOROOT/src/runtime/panic.go in runtime.gopanic at line 884

Tags

Tag Value
Command mt start-sql
Environment v23.1.12
Go Version go1.19.13
Platform linux amd64
Distribution CCL
Cockroach Release v23.1.11-596-gfb1ed73d9d8
Cockroach SHA fb1ed73d9d88f459c3cda5866fae29831cce06b4
# of CPUs 16
# of Goroutines 280

Jira issue: CRDB-33107
@cockroach-sentry cockroach-sentry added O-sentry Originated from an in-the-wild panic report. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Nov 2, 2023
@yuzefovich
Copy link
Member

dup of #109060 and https://github.com/cockroachlabs/support/issues/2695, but this is on serverless, so we might be able to get to the bottom of it

@yuzefovich yuzefovich changed the title Sentry: panic.go:884: runtime error: index out of range [2] with length 2 (1) attached stack trace -- stack trace: | runtime.gopanic | GOROOT/src/runtime/panic.go:884 | runtime.goPanicIndex ... sql: v23.1.11: index out of range in quantile.fixMalformed Nov 2, 2023
@yuzefovich yuzefovich added the T-sql-queries SQL Queries Team label Nov 2, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Nov 2, 2023
@DrewKimball
Copy link
Collaborator

Probable dupe of #113645

DrewKimball added a commit to DrewKimball/cockroach that referenced this issue Nov 2, 2023
@DrewKimball
sql/stats: don't use linear regression with NaN for stats forecasting
50a042d 
This patch adds a method to the quantile function, `invalid`, which checks
for `NaN` values within the function. These indicate a failure to derive
a linear regression model for the observed histograms, and can lead to
internal errors and panics if not caught. Stats forecasting now checks this
method before attempting to use a quantile function to derive a histogram
prediction.

Fixes cockroachdb#113645
Fixes cockroachdb#113680

Release note (bug fix): Fixed a bug that could cause internal errors or
panics while attempting to forecast statistics on a numeric column.
@DrewKimball DrewKimball mentioned this issue Nov 2, 2023
Merged
DrewKimball added a commit to DrewKimball/cockroach that referenced this issue Nov 2, 2023
@DrewKimball
sql/stats: don't use linear regression with NaN for stats forecasting
dbd74be 
This patch adds a method to the quantile function, `invalid`, which checks
for `NaN` and `+/-Inf` values within the function. These indicate a failure
to derive a linear regression model for the observed histograms, and can lead
to internal errors and panics if not caught. Stats forecasting now checks this
method before attempting to use a quantile function to derive a histogram
prediction. This patch also reverts 120132e, since `fixMalformed` is no longer
expected to return an error.

Fixes cockroachdb#113645
Fixes cockroachdb#113680

Release note (bug fix): Fixed a bug that could cause internal errors or
panics while attempting to forecast statistics on a numeric column.
@michae2 michae2 moved this from Triage to Active in SQL Queries Nov 2, 2023
craig bot pushed a commit that referenced this issue Nov 3, 2023
@DrewKimball
Merge #113712
f6d6a9d 
113712: sql/stats: don't use linear regression with NaN for stats forecasting r=DrewKimball a=DrewKimball

This patch adds a method to the quantile function, `invalid`, which checks for `NaN` values within the function. These indicate a failure to derive a linear regression model for the observed histograms, and can lead to internal errors and panics if not caught. Stats forecasting now checks this method before attempting to use a quantile function to derive a histogram prediction.

Fixes #113645
Fixes #113680

Release note (bug fix): Fixed a bug that could cause internal errors or panics while attempting to forecast statistics on a numeric column.

Co-authored-by: Drew Kimball <[email protected]>
@craig craig bot closed this as completed in 050b37c Nov 3, 2023
@github-project-automation github-project-automation bot moved this from Active to Done in SQL Queries Nov 3, 2023
blathers-crl bot pushed a commit that referenced this issue Nov 3, 2023
@DrewKimball
sql/stats: don't use linear regression with NaN for stats forecasting
e755ed4 
This patch adds a method to the quantile function, `invalid`, which checks
for `NaN` and `+/-Inf` values within the function. These indicate a failure
to derive a linear regression model for the observed histograms, and can lead
to internal errors and panics if not caught. Stats forecasting now checks this
method before attempting to use a quantile function to derive a histogram
prediction. This patch also reverts 120132e, since `fixMalformed` is no longer
expected to return an error.

Fixes #113645
Fixes #113680

Release note (bug fix): Fixed a bug that could cause internal errors or
panics while attempting to forecast statistics on a numeric column.
@blathers-crl blathers-crl bot mentioned this issue Nov 3, 2023
Merged
DrewKimball added a commit to DrewKimball/cockroach that referenced this issue Nov 3, 2023
@DrewKimball
sql/stats: don't use linear regression with NaN for stats forecasting
a37ecb7 
This patch adds a method to the quantile function, `invalid`, which checks
for `NaN` and `+/-Inf` values within the function. These indicate a failure
to derive a linear regression model for the observed histograms, and can lead
to internal errors and panics if not caught. Stats forecasting now checks this
method before attempting to use a quantile function to derive a histogram
prediction. This patch also reverts 120132e, since `fixMalformed` is no longer
expected to return an error.

Fixes cockroachdb#113645
Fixes cockroachdb#113680

Release note (bug fix): Fixed a bug that could cause internal errors or
panics while attempting to forecast statistics on a numeric column.
@DrewKimball DrewKimball mentioned this issue Nov 3, 2023
Merged
DrewKimball added a commit to DrewKimball/cockroach that referenced this issue Nov 3, 2023
@DrewKimball
sql/stats: don't use linear regression with NaN for stats forecasting
4f169f7 
This patch adds a method to the quantile function, `invalid`, which checks
for `NaN` and `+/-Inf` values within the function. These indicate a failure
to derive a linear regression model for the observed histograms, and can lead
to internal errors and panics if not caught. Stats forecasting now checks this
method before attempting to use a quantile function to derive a histogram
prediction. This patch also reverts 120132e, since `fixMalformed` is no longer
expected to return an error.

Fixes cockroachdb#113645
Fixes cockroachdb#113680

Release note (bug fix): Fixed a bug that could cause internal errors or
panics while attempting to forecast statistics on a numeric column.
@DrewKimball DrewKimball mentioned this issue Nov 3, 2023
Merged
DrewKimball added a commit to DrewKimball/cockroach that referenced this issue Nov 4, 2023
@DrewKimball
sql/stats: don't use linear regression with NaN for stats forecasting
18304b8 
This patch adds a method to the quantile function, `invalid`, which checks
for `NaN` and `+/-Inf` values within the function. These indicate a failure
to derive a linear regression model for the observed histograms, and can lead
to internal errors and panics if not caught. Stats forecasting now checks this
method before attempting to use a quantile function to derive a histogram
prediction. This patch also reverts 120132e, since `fixMalformed` is no longer
expected to return an error.

Fixes cockroachdb#113645
Fixes cockroachdb#113680

Release note (bug fix): Fixed a bug that could cause internal errors or
panics while attempting to forecast statistics on a numeric column.
@DrewKimball DrewKimball mentioned this issue Nov 4, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue Nov 6, 2023
@DrewKimball
sql/stats: don't use linear regression with NaN for stats forecasting
036d7b7 
This patch adds a method to the quantile function, `invalid`, which checks
for `NaN` and `+/-Inf` values within the function. These indicate a failure
to derive a linear regression model for the observed histograms, and can lead
to internal errors and panics if not caught. Stats forecasting now checks this
method before attempting to use a quantile function to derive a histogram
prediction. This patch also reverts 120132e, since `fixMalformed` is no longer
expected to return an error.

Fixes #113645
Fixes #113680

Release note (bug fix): Fixed a bug that could cause internal errors or
panics while attempting to forecast statistics on a numeric column.
DrewKimball added a commit to DrewKimball/cockroach that referenced this issue Nov 6, 2023
@DrewKimball
sql/stats: don't use linear regression with NaN for stats forecasting
1afac4f 
This patch adds a method to the quantile function, `invalid`, which checks
for `NaN` and `+/-Inf` values within the function. These indicate a failure
to derive a linear regression model for the observed histograms, and can lead
to internal errors and panics if not caught. Stats forecasting now checks this
method before attempting to use a quantile function to derive a histogram
prediction. This patch also reverts 120132e, since `fixMalformed` is no longer
expected to return an error.

Fixes cockroachdb#113645
Fixes cockroachdb#113680

Release note (bug fix): Fixed a bug that could cause internal errors or
panics while attempting to forecast statistics on a numeric column.
@DrewKimball DrewKimball mentioned this issue Nov 6, 2023
Merged
@yuzefovich yuzefovich mentioned this issue Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-sentry Originated from an in-the-wild panic report. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql/stats: don't use linear regression with NaN for stats forecasting DrewKimball/cockroach
3 participants
@yuzefovich @DrewKimball @cockroach-sentry