Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add prober for region liveness #113160

Closed
fqazi opened this issue Oct 26, 2023 · 0 comments · Fixed by #113231
Closed

sql: add prober for region liveness #113160

fqazi opened this issue Oct 26, 2023 · 0 comments · Fixed by #113231
Assignees
@fqazi
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@fqazi
Copy link
Collaborator

fqazi commented Oct 26, 2023 •
edited by rimadeodhar
Loading

Introduce a new interface to detect liveness for a region, which will help implement interfaces to detect when regions are down within a multi-tenant, multi-region cluster. This issue only focuses on adding this interface and testing to validate region death detection functions correctly.

Additionally, introduce a cluster setting required to control this work

Jira issue: CRDB-32781

Epic CC-24173
@fqazi fqazi added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Oct 26, 2023
@fqazi fqazi self-assigned this Oct 26, 2023
@fqazi fqazi mentioned this issue Oct 26, 2023
Closed
@fqazi fqazi mentioned this issue Oct 27, 2023
Merged
fqazi added a commit to fqazi/cockroach that referenced this issue Oct 30, 2023
@fqazi
regionliveness: add prober for detecting live regions
94039fa 
Previously, queries into system tables had no way of tracking the
liveness of regions when query system tables. As a result, system tables
for tracking state information could not be configured as SURVIVE ZONE
FAILURE, since a full region outage, will cause schema changes, jobs,
and other infrastructure to get stuck on lost regions. To address this,
this patch starts initial work with a region-liveness Prober interface,
allowing these different subsystems to detect *live* regions and query
by region. This patch also adds a cluster setting for gating the probing
interface (sql.region_liveness.enabled).

EPIC: CRDB-28158
Fixes: cockroachdb#113160
Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Nov 6, 2023
@fqazi
regionliveness: add prober for detecting live regions
cd45ced 
Previously, queries into system tables had no way of tracking the
liveness of regions when query system tables. As a result, system tables
for tracking state information could not be configured as SURVIVE ZONE
FAILURE, since a full region outage, will cause schema changes, jobs,
and other infrastructure to get stuck on lost regions. To address this,
this patch starts initial work with a region-liveness Prober interface,
allowing these different subsystems to detect *live* regions and query
by region. This patch also adds a cluster setting for gating the probing
interface (sql.region_liveness.enabled).

EPIC: CRDB-28158
Fixes: cockroachdb#113160
Release note: None
craig bot pushed a commit that referenced this issue Nov 9, 2023
@fqazi
Merge #113231
14eb6cb 
113231: regionliveness: add prober for detecting live regions r=fqazi a=fqazi

Previously, queries into system tables had no way of tracking the liveness of regions when query system tables. As a result, system tables for tracking state information could not be configured as SURVIVE ZONE FAILURE, since a full region outage, will cause schema changes, jobs, and other infrastructure to get stuck on lost regions. To address this, this patch starts initial work with a region-liveness Prober interface, allowing these different subsystems to detect *live* regions and query by region. This patch also adds a cluster setting for gating the probing interface (sql.region_liveness.enabled).

EPIC: CRDB-28158
Fixes: #113160
Release note: None

Co-authored-by: Faizan Qazi <[email protected]>
@craig craig bot closed this as completed in 21ec385 Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Foundations
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

regionliveness: add prober for detecting live regions fqazi/cockroach
1 participant
@fqazi