Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test: TestLogic_trigram_builtins failed #107461

Closed
cockroach-teamcity opened this issue Jul 24, 2023 · 8 comments · Fixed by #107490
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 24, 2023

pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test.TestLogic_trigram_builtins failed with artifacts on master @ 06fb4c1b02fc90f8ef17ec1342bb6ce600278925:

        "COCKROACH_INTERNAL_DISABLE_METAMORPHIC_TESTING=false" to disable all random test variables altogether.
*
* WARNING: test tenant requested by configuration, but code organization prevents start!
* OSS binaries do not include enterprise features
*
    logic.go:2925: 
         
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/7695/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:45: SELECT similarity(a, b) FROM (VALUES
            ('', ''),
            ('foo', ''),
            ('', 'foo'),
            ('foo', NULL),
            (NULL, 'foo'),
            (NULL, NULL),
            ('foo', 'bar'),
            ('foo', 'far'),
            ('foo', 'for'),
            ('foo', 'foo')
          ) tbl(a, b)
        expected:
            0
            0
            0
            NULL
            NULL
            NULL
            0
            0.142857142857143
            0.333333333333333
            1
            
        but found (query options: "nosort") :
            0
            0
            0
            NULL
            NULL
            NULL
            0
            0.14285714285714285
            0.3333333333333333
            1
            
[17:03:32] --- done: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/7695/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins with config local-mixed-22.2-23.1: 6 tests, 1 failures
    logic.go:3983: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/7695/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:70: error while processing
    logic.go:3983: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/7695/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:70: too many errors encountered, skipping the rest of the input
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/5e67fe52d711043100a1ff1e2183dfca/logTestLogic_trigram_builtins2883590916
--- FAIL: TestLogic_trigram_builtins (0.65s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-30056

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team labels Jul 24, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Jul 24, 2023
@cockroach-teamcity
Copy link
Member Author

pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test.TestLogic_trigram_builtins failed with artifacts on master @ c917a6bd896730c86867e2ed6399725ec10e0ac2:

        "COCKROACH_INTERNAL_DISABLE_METAMORPHIC_TESTING=false" to disable all random test variables altogether.
*
* WARNING: test tenant requested by configuration, but code organization prevents start!
* OSS binaries do not include enterprise features
*
    logic.go:2925: 
         
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/23/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:45: SELECT similarity(a, b) FROM (VALUES
            ('', ''),
            ('foo', ''),
            ('', 'foo'),
            ('foo', NULL),
            (NULL, 'foo'),
            (NULL, NULL),
            ('foo', 'bar'),
            ('foo', 'far'),
            ('foo', 'for'),
            ('foo', 'foo')
          ) tbl(a, b)
        expected:
            0
            0
            0
            NULL
            NULL
            NULL
            0
            0.142857142857143
            0.333333333333333
            1
            
        but found (query options: "nosort") :
            0
            0
            0
            NULL
            NULL
            NULL
            0
            0.14285714285714285
            0.3333333333333333
            1
            
[17:36:26] --- done: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/23/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins with config local-mixed-22.2-23.1: 6 tests, 1 failures
    logic.go:3983: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/23/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:70: error while processing
    logic.go:3983: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/23/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:70: too many errors encountered, skipping the rest of the input
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/5e67fe52d711043100a1ff1e2183dfca/logTestLogic_trigram_builtins3216878402
--- FAIL: TestLogic_trigram_builtins (0.72s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test.TestLogic_trigram_builtins failed with artifacts on master @ c917a6bd896730c86867e2ed6399725ec10e0ac2:

=== RUN   TestLogic_trigram_builtins
    test_log_scope.go:167: test logs captured to: /artifacts/tmp/_tmp/5e67fe52d711043100a1ff1e2183dfca/logTestLogic_trigram_builtins1416715066
    test_log_scope.go:81: use -show-logs to present logs inline
[18:52:24] setting distsql_workmem='78027B';
    logic.go:2925: 
         
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/6168/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:45: SELECT similarity(a, b) FROM (VALUES
            ('', ''),
            ('foo', ''),
            ('', 'foo'),
            ('foo', NULL),
            (NULL, 'foo'),
            (NULL, NULL),
            ('foo', 'bar'),
            ('foo', 'far'),
            ('foo', 'for'),
            ('foo', 'foo')
          ) tbl(a, b)
        expected:
            0
            0
            0
            NULL
            NULL
            NULL
            0
            0.142857142857143
            0.333333333333333
            1
            
        but found (query options: "nosort") :
            0
            0
            0
            NULL
            NULL
            NULL
            0
            0.14285714285714285
            0.3333333333333333
            1
            
[18:52:24] --- done: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/6168/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins with config local-mixed-22.2-23.1: 6 tests, 1 failures
    logic.go:3983: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/6168/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:70: error while processing
    logic.go:3983: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/6168/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:70: too many errors encountered, skipping the rest of the input
    panic.go:522: -- test log scope end --
--- FAIL: TestLogic_trigram_builtins (0.55s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@michae2
Copy link
Collaborator

michae2 commented Jul 24, 2023

@rharding6373 and I are trying to figure out if this is fallout from #106552

@mgartner
Copy link
Collaborator

./dev test './pkg/sql/logictest/tests/local' -f 'TestLogic_trigram' fails consistently for me. I wonder how this passed CI?

@cockroach-teamcity
Copy link
Member Author

pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test.TestLogic_trigram_builtins failed with artifacts on master @ 4618dbf07f1fe42e26e16c95b1b495119ad5d267:

        "COCKROACH_INTERNAL_DISABLE_METAMORPHIC_TESTING=false" to disable all random test variables altogether.
*
* WARNING: test tenant requested by configuration, but code organization prevents start!
* OSS binaries do not include enterprise features
*
    logic.go:2925: 
         
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/9028/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:45: SELECT similarity(a, b) FROM (VALUES
            ('', ''),
            ('foo', ''),
            ('', 'foo'),
            ('foo', NULL),
            (NULL, 'foo'),
            (NULL, NULL),
            ('foo', 'bar'),
            ('foo', 'far'),
            ('foo', 'for'),
            ('foo', 'foo')
          ) tbl(a, b)
        expected:
            0
            0
            0
            NULL
            NULL
            NULL
            0
            0.142857142857143
            0.333333333333333
            1
            
        but found (query options: "nosort") :
            0
            0
            0
            NULL
            NULL
            NULL
            0
            0.14285714285714285
            0.3333333333333333
            1
            
[18:54:06] --- done: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/9028/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins with config local-mixed-22.2-23.1: 6 tests, 1 failures
    logic.go:3983: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/9028/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:70: error while processing
    logic.go:3983: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/9028/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:70: too many errors encountered, skipping the rest of the input
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/5e67fe52d711043100a1ff1e2183dfca/logTestLogic_trigram_builtins64484466
--- FAIL: TestLogic_trigram_builtins (0.58s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@michae2
Copy link
Collaborator

michae2 commented Jul 24, 2023

./dev test './pkg/sql/logictest/tests/local' -f 'TestLogic_trigram' fails consistently for me. I wonder how this passed CI?

I think it has something to do with Intel vs ARM procs.

michae2 added a commit to michae2/cockroach that referenced this issue Jul 24, 2023
In cockroachdb#106552 we tried changing float normalization to use base 2 instead
of base 10 (in other words, to use `math.Frexp` instead of our
hand-rolled `normalize`). This appears to have broken a logic test, so
revert back to the pre-existing base 10 normalization.

Fixes: cockroachdb#107461

Release note: None
@michae2
Copy link
Collaborator

michae2 commented Jul 24, 2023

@mgartner would you be willing to try #107490 on your laptop?

craig bot pushed a commit that referenced this issue Jul 24, 2023
107490: testutils/floatcmp: revert to base-10 normalization in FloatsMatch r=rharding6373 a=michae2

In #106552 we tried changing float normalization to use base 2 instead of base 10 (in other words, to use `math.Frexp` instead of our hand-rolled `normalize`). This appears to have broken a logic test, so revert back to the pre-existing base 10 normalization.

Fixes: #107461

Release note: None

Co-authored-by: Michael Erickson <[email protected]>
@cockroach-teamcity
Copy link
Member Author

pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test.TestLogic_trigram_builtins failed with artifacts on master @ acc75f4605294f2c872ceb63b12f2c9605711d3b:

        "COCKROACH_INTERNAL_DISABLE_METAMORPHIC_TESTING=false" to disable all random test variables altogether.
*
* WARNING: test tenant requested by configuration, but code organization prevents start!
* OSS binaries do not include enterprise features
*
    logic.go:2925: 
         
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/11305/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:45: SELECT similarity(a, b) FROM (VALUES
            ('', ''),
            ('foo', ''),
            ('', 'foo'),
            ('foo', NULL),
            (NULL, 'foo'),
            (NULL, NULL),
            ('foo', 'bar'),
            ('foo', 'far'),
            ('foo', 'for'),
            ('foo', 'foo')
          ) tbl(a, b)
        expected:
            0
            0
            0
            NULL
            NULL
            NULL
            0
            0.142857142857143
            0.333333333333333
            1
            
        but found (query options: "nosort") :
            0
            0
            0
            NULL
            NULL
            NULL
            0
            0.14285714285714285
            0.3333333333333333
            1
            
[19:51:42] --- done: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/11305/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins with config local-mixed-22.2-23.1: 6 tests, 1 failures
    logic.go:3983: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/11305/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:70: error while processing
    logic.go:3983: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/11305/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test_/local-mixed-22_2-23_1_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/trigram_builtins:70: too many errors encountered, skipping the rest of the input
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/5e67fe52d711043100a1ff1e2183dfca/logTestLogic_trigram_builtins1090070100
--- FAIL: TestLogic_trigram_builtins (0.58s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@craig craig bot closed this as completed in aff21b6 Jul 24, 2023
@github-project-automation github-project-automation bot moved this from Active to Done in SQL Queries Jul 24, 2023
rharding6373 pushed a commit to rharding6373/cockroach that referenced this issue Sep 13, 2023
In cockroachdb#106552 we tried changing float normalization to use base 2 instead
of base 10 (in other words, to use `math.Frexp` instead of our
hand-rolled `normalize`). This appears to have broken a logic test, so
revert back to the pre-existing base 10 normalization.

Fixes: cockroachdb#107461

Release note: None
rharding6373 pushed a commit to rharding6373/cockroach that referenced this issue Sep 13, 2023
In cockroachdb#106552 we tried changing float normalization to use base 2 instead
of base 10 (in other words, to use `math.Frexp` instead of our
hand-rolled `normalize`). This appears to have broken a logic test, so
revert back to the pre-existing base 10 normalization.

Fixes: cockroachdb#107461

Release note: None
rharding6373 pushed a commit to rharding6373/cockroach that referenced this issue Sep 15, 2023
In cockroachdb#106552 we tried changing float normalization to use base 2 instead
of base 10 (in other words, to use `math.Frexp` instead of our
hand-rolled `normalize`). This appears to have broken a logic test, so
revert back to the pre-existing base 10 normalization.

Fixes: cockroachdb#107461

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants