-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test: TestLogic_trigram_builtins failed #107461
Comments
pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test.TestLogic_trigram_builtins failed with artifacts on master @ c917a6bd896730c86867e2ed6399725ec10e0ac2:
|
pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test.TestLogic_trigram_builtins failed with artifacts on master @ c917a6bd896730c86867e2ed6399725ec10e0ac2:
|
@rharding6373 and I are trying to figure out if this is fallout from #106552 |
|
pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test.TestLogic_trigram_builtins failed with artifacts on master @ 4618dbf07f1fe42e26e16c95b1b495119ad5d267:
|
I think it has something to do with Intel vs ARM procs. |
In cockroachdb#106552 we tried changing float normalization to use base 2 instead of base 10 (in other words, to use `math.Frexp` instead of our hand-rolled `normalize`). This appears to have broken a logic test, so revert back to the pre-existing base 10 normalization. Fixes: cockroachdb#107461 Release note: None
107490: testutils/floatcmp: revert to base-10 normalization in FloatsMatch r=rharding6373 a=michae2 In #106552 we tried changing float normalization to use base 2 instead of base 10 (in other words, to use `math.Frexp` instead of our hand-rolled `normalize`). This appears to have broken a logic test, so revert back to the pre-existing base 10 normalization. Fixes: #107461 Release note: None Co-authored-by: Michael Erickson <[email protected]>
pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test.TestLogic_trigram_builtins failed with artifacts on master @ acc75f4605294f2c872ceb63b12f2c9605711d3b:
|
In cockroachdb#106552 we tried changing float normalization to use base 2 instead of base 10 (in other words, to use `math.Frexp` instead of our hand-rolled `normalize`). This appears to have broken a logic test, so revert back to the pre-existing base 10 normalization. Fixes: cockroachdb#107461 Release note: None
In cockroachdb#106552 we tried changing float normalization to use base 2 instead of base 10 (in other words, to use `math.Frexp` instead of our hand-rolled `normalize`). This appears to have broken a logic test, so revert back to the pre-existing base 10 normalization. Fixes: cockroachdb#107461 Release note: None
In cockroachdb#106552 we tried changing float normalization to use base 2 instead of base 10 (in other words, to use `math.Frexp` instead of our hand-rolled `normalize`). This appears to have broken a logic test, so revert back to the pre-existing base 10 normalization. Fixes: cockroachdb#107461 Release note: None
pkg/sql/logictest/tests/local-mixed-22.2-23.1/local-mixed-22_2-23_1_test.TestLogic_trigram_builtins failed with artifacts on master @ 06fb4c1b02fc90f8ef17ec1342bb6ce600278925:
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-30056
The text was updated successfully, but these errors were encountered: