Add a check in debug doctor for a cluster at risk of indexes with invalid encoding #106794
Assignees
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
O-support
Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
smcvey
added
the
C-enhancement
rimadeodhar
changed the title
rafiss
added
the
T-sql-foundations
rafiss
added
the
O-support
|
Related to #106739 also. |
fqazi
added a commit
to fqazi/cockroach
that referenced
this issue
Jul 14, 2023
…olumns Previously, we had a bug were it was possible that the primary indexes was not storing some non-virtual columns. Unfortunately, adding validation in all cases would break existing customers, so as a safety we have added validation to crdb_internal.invalid_objects and the debug doctor command. To address this, this patch adds a new validation level only for invalid_objects / doctor. Fixes: cockroachdb#106794 Informs: cockroachdb#106739 Release note: None
fqazi
added a commit
to fqazi/cockroach
that referenced
this issue
Jul 18, 2023
…olumns Previously, we had a bug were it was possible that the primary indexes was not storing some non-virtual columns. Unfortunately, adding validation in all cases would break existing customers, so as a safety we have added validation to crdb_internal.invalid_objects and the debug doctor command. To address this, this patch adds a new validation level only for invalid_objects / doctor. Fixes: cockroachdb#106794 Informs: cockroachdb#106739 Release note: None
rafiss
pushed a commit
that referenced
this issue
Jul 18, 2023
…olumns Previously, we had a bug were it was possible that the primary indexes was not storing some non-virtual columns. Unfortunately, adding validation in all cases would break existing customers, so as a safety we have added validation to crdb_internal.invalid_objects and the debug doctor command. To address this, this patch adds a new validation level only for invalid_objects / doctor. Fixes: #106794 Informs: #106739 Release note: None
rafiss
pushed a commit
that referenced
this issue
Jul 18, 2023
…olumns Previously, we had a bug were it was possible that the primary indexes was not storing some non-virtual columns. Unfortunately, adding validation in all cases would break existing customers, so as a safety we have added validation to crdb_internal.invalid_objects and the debug doctor command. To address this, this patch adds a new validation level only for invalid_objects / doctor. Fixes: #106794 Informs: #106739 Release note: None
celiala
pushed a commit
that referenced
this issue
Jul 26, 2023
…olumns Previously, we had a bug were it was possible that the primary indexes was not storing some non-virtual columns. Unfortunately, adding validation in all cases would break existing customers, so as a safety we have added validation to crdb_internal.invalid_objects and the debug doctor command. To address this, this patch adds a new validation level only for invalid_objects / doctor. Fixes: #106794 Informs: #106739 Release note: None (cherry picked from commit 353e9c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Please add an additional check to
cockroach debug doctorwhich checks the descriptors looking for tables that are at risk of invalid encoding.Additional context
We only need to have this check in the latest 23.1 binary, there's no need to backport it to earlier versions.
Jira issue: CRDB-29717
Epic CRDB-28665
The text was updated successfully, but these errors were encountered: