Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: acceptance/version-upgrade failed #105032

Closed
cockroach-teamcity opened this issue Jun 16, 2023 · 5 comments · Fixed by #108357
Closed

roachtest: acceptance/version-upgrade failed #105032

cockroach-teamcity opened this issue Jun 16, 2023 · 5 comments · Fixed by #108357
Assignees
@adityamaru
Labels
A-jobs branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-jobs
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jun 16, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.acceptance/version-upgrade failed with artifacts on release-23.1 @ cf795114db6331e95f7b97ff411065b22626c3cb:

test artifacts and logs in: /artifacts/acceptance/version-upgrade/run_1
(mixedversion.go:410).Run: mixed-version test failure while running step 29 (run "test schema change step"): output in run_055721.704588390_n3_workload-run-schemac: ./workload run schemachange {pgurl:1-4} --concurrency 2 --max-ops 10 --verbose 1 returned: COMMAND_PROBLEM: ssh verbose log retained in ssh_055722.380585675_n3_workload-run-schemac.log: exit status 1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

/cc @cockroachdb/test-eng

This test on roachdash | Improve this report!

Jira issue: CRDB-28828
@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Jun 16, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Jun 16, 2023
@blathers-crl blathers-crl bot added the T-testeng TestEng Team label Jun 16, 2023
@renatolabs
Copy link
Contributor

Instance of #103239 (cc @adityamaru).

@adityamaru adityamaru removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Jun 16, 2023
@cockroach-teamcity
Copy link
Member Author

roachtest.acceptance/version-upgrade failed with artifacts on release-23.1 @ f13c021bb97531ac876c2c1438a9d4bfc80d1c32:

(mixedversion.go:410).Run: mixed-version test failure while running step 30 (run "test schema change step"): output in run_055430.496290155_n4_workload-run-schemac: ./workload run schemachange {pgurl:1-4} --concurrency 2 --max-ops 10 --verbose 1 returned: COMMAND_PROBLEM: exit status 1
test artifacts and logs in: /artifacts/acceptance/version-upgrade/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@renatolabs
Copy link
Contributor

renatolabs commented Jun 29, 2023 •
edited
Loading

***UNEXPECTED ERROR; Received an unexpected execution error.: ERROR: descriptor ID generator unavailable, migration in progress, retry later (SQLSTATE XXUUU)

@fqazi is this a bug in the workload or cockroach?

@fqazi
Copy link
Collaborator

fqazi commented Jun 29, 2023

@renatolabs Thats a workload bug, let me get a PR for this and the other issue we have seen today

@dt dt mentioned this issue Jul 5, 2023
Closed
@blathers-crl blathers-crl bot added the A-jobs label Jul 25, 2023
@renatolabs
Copy link
Contributor

Moving ownership to jobs since this is ultimately #103239.

@renatolabs renatolabs removed the T-testeng TestEng Team label Jul 25, 2023
@adityamaru adityamaru mentioned this issue Aug 8, 2023
Merged
craig bot pushed a commit that referenced this issue Aug 12, 2023
@adityamaru @erikgrinaker
Merge #108357 #108583
9184ffb 
108357: jobs: fix mixed-version jobs flake r=knz a=adityamaru

Similar to #107570 this is a short term fix for when an a query is executed with an AS OF SYSTEM TIME picks a transaction timestamp before the job_info migration has run. In which case parts of the jobs infrastructure will attempt to query the job_info column even though it doesn't exist at the transaction's timestamp.

As a short term fix, when we encounter an UndefinedObject error for the job_info table we generate a synthetic retryable error so that the txn is pushed to a higher timestamp at which the upgrade will have completed and the job_info table will be visible. The longer term fix is being tracked in #106764.

On master I can no longer reproduce the failure in #105032 but on 23.1 with this change I can successfully run 30 iterations of the test on a seed (-8690666577594439584) which previously saw occurrences of this flake.

Fixes: #103239
Fixes: #105032

Release note: None

108583: rangefeed: deflake `TestBudgetReleaseOnOneStreamError` r=erikgrinaker a=erikgrinaker

The test could fail with `REASON_SLOW_CONSUMER` if the registration goroutine did not drain the queue in time (1 ms). Increase the timeout.

Resolves #108555.

Epic: none
Release note: None

Co-authored-by: adityamaru <[email protected]>
Co-authored-by: Erik Grinaker <[email protected]>
@craig craig bot closed this as completed in 79cc2ea Aug 12, 2023
@blathers-crl blathers-crl bot mentioned this issue Aug 12, 2023
Closed
blathers-crl bot pushed a commit that referenced this issue Aug 12, 2023
@adityamaru
jobs: fix mixed-version jobs flake
36e38cd 
Similar to #107570
this is a short term fix for when an a query is executed with an AS OF SYSTEM TIME
picks a transaction timestamp before the job_info migration has run.
In which case parts of the jobs infrastructure will attempt to query
the job_info column even though it doesn't exist at the transaction's timestamp.

As a short term fix, when we encounter an UndefinedObject error for the job_info table
we generate a synthetic retryable error so that the txn is pushed to a higher timestamp
at which the upgrade will have completed and the job_info table will be visible.
The longer term fix is being tracked in #106764.

On master I can no longer reproduce the failure in #105032 but
on 23.1 with this change I can successfully run 30 iterations of the test
on a seed (-8690666577594439584) which previously saw occurrences
of this flake.

Fixes: #103239
Fixes: #105032

Release note: None
adityamaru added a commit that referenced this issue Aug 18, 2023
@adityamaru
jobs: fix mixed-version jobs flake
c46c488 
Similar to #107570
this is a short term fix for when an a query is executed with an AS OF SYSTEM TIME
picks a transaction timestamp before the job_info migration has run.
In which case parts of the jobs infrastructure will attempt to query
the job_info column even though it doesn't exist at the transaction's timestamp.

As a short term fix, when we encounter an UndefinedObject error for the job_info table
we generate a synthetic retryable error so that the txn is pushed to a higher timestamp
at which the upgrade will have completed and the job_info table will be visible.
The longer term fix is being tracked in #106764.

On master I can no longer reproduce the failure in #105032 but
on 23.1 with this change I can successfully run 30 iterations of the test
on a seed (-8690666577594439584) which previously saw occurrences
of this flake.

Fixes: #103239
Fixes: #105032

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityamaru adityamaru

Labels
A-jobs branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-jobs
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

jobs: fix mixed-version jobs flake adityamaru/cockroach
4 participants
@fqazi @adityamaru @cockroach-teamcity @renatolabs