Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: leaked goroutine in TestIngest/batch=default #104639

Closed
irfansharif opened this issue Jun 9, 2023 · 1 comment · Fixed by #104715
Closed

backupccl: leaked goroutine in TestIngest/batch=default #104639

irfansharif opened this issue Jun 9, 2023 · 1 comment · Fixed by #104715
Assignees
@stevendanna
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). skipped-test T-disaster-recovery

Comments

@irfansharif
Copy link
Contributor

irfansharif commented Jun 9, 2023 •
edited by cockroach-jira-scripts
Loading

Describe the problem

See recent test history. It's failing with:

=== CONT  TestIngest/batch=default
    restore_data_processor_test.go:438: Leaked goroutine: goroutine 135433 [select]:
        github.com/cockroachdb/cockroach/pkg/util/log.(*fileSink).gcDaemon(0xc013272410, {0x787d8f8, 0xc005f22240})
        	github.com/cockroachdb/cockroach/pkg/util/log/file_log_gc.go:25 +0x7f
        created by github.com/cockroachdb/cockroach/pkg/util/log.ApplyConfig
        	github.com/cockroachdb/cockroach/pkg/util/log/flags.go:306 +0x112a
        Leaked goroutine: goroutine 135434 [select]:
        github.com/cockroachdb/cockroach/pkg/util/log.(*fileSink).gcDaemon(0xc0132724e0, {0x787d8f8, 0xc005f22240})
        	github.com/cockroachdb/cockroach/pkg/util/log/file_log_gc.go:25 +0x7f
        created by github.com/cockroachdb/cockroach/pkg/util/log.ApplyConfig
        	github.com/cockroachdb/cockroach/pkg/util/log/flags.go:306 +0x112a
        Leaked goroutine: goroutine 135435 [select]:
        github.com/cockroachdb/cockroach/pkg/util/log.(*fileSink).gcDaemon(0xc0132725b0, {0x787d8f8, 0xc005f22240})
        	github.com/cockroachdb/cockroach/pkg/util/log/file_log_gc.go:25 +0x7f
        created by github.com/cockroachdb/cockroach/pkg/util/log.ApplyConfig
        	github.com/cockroachdb/cockroach/pkg/util/log/flags.go:306 +0x112a
        Leaked goroutine: goroutine 135436 [select]:
        github.com/cockroachdb/cockroach/pkg/util/log.(*fileSink).gcDaemon(0xc013272680, {0x787d8f8, 0xc005f22240})
        	github.com/cockroachdb/cockroach/pkg/util/log/file_log_gc.go:25 +0x7f
        created by github.com/cockroachdb/cockroach/pkg/util/log.ApplyConfig
        	github.com/cockroachdb/cockroach/pkg/util/log/flags.go:306 +0x112a

Jira issue: CRDB-28648
@irfansharif irfansharif added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). A-disaster-recovery T-disaster-recovery labels Jun 9, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jun 9, 2023

cc @cockroachdb/disaster-recovery

@irfansharif irfansharif mentioned this issue Jun 9, 2023
Merged
irfansharif added a commit to irfansharif/cockroach that referenced this issue Jun 9, 2023
@irfansharif
backupccl: skip TestIngest/batch=default
769c096 
It's flakey. See cockroachdb#104639.

Release note: None
irfansharif added a commit to irfansharif/cockroach that referenced this issue Jun 9, 2023
@irfansharif
backupccl: skip TestIngest/batch=default
765c464 
It's flakey. See cockroachdb#104639.

Release note: None
@stevendanna stevendanna self-assigned this Jun 9, 2023
@stevendanna stevendanna mentioned this issue Jun 12, 2023
Merged
craig bot pushed a commit that referenced this issue Jun 12, 2023
@stevendanna
Merge #104715
cdc8439 
104715: backupccl: unskip TestIngest r=msbutler a=stevendanna

The issue here was that we recently added a log.Scope(t).Close(t) call to this test. However, log.Scope(t) creates a goroutine that is only cleaned up when the defer is called. As a result a leaktest inside the given subtests failed.

Here, we move the log scope into the subtest as well.

Fixes #104639

Release note: None

Co-authored-by: Steven Danna <[email protected]>
@craig craig bot closed this as completed in 23ab824 Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevendanna stevendanna

Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). skipped-test T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backupccl: unskip TestIngest stevendanna/cockroach
2 participants
@stevendanna @irfansharif