Skip to content

Commit

Permalink
changefeedccl: fix deadlock in mocksyncproducer
Browse files Browse the repository at this point in the history
TestChangefeedKafkaMessageTooLarge would flake sometimes with goroutines
blocked on sending into the mocksyncproducer feedCh and would result in
a "Slow on quiesce" error. This is likely due to the jobFeed shutting
down and therefore no longer reading from the feedCh.

Release note: None
  • Loading branch information
samiskin committed Nov 9, 2022
1 parent d6ae965 commit ffbc28d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkg/ccl/changefeedccl/testfeed_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1608,7 +1608,10 @@ func (s *fakeKafkaSink) Dial() error {
return err
}
}
s.feedCh <- m
select {
case s.feedCh <- m:
case <-s.tg.done:
}
return nil
},
}}, nil
Expand Down

0 comments on commit ffbc28d

Please sign in to comment.