Skip to content

Commit

Permalink
Merge #91775
Browse files Browse the repository at this point in the history
91775: roachtest: add placeholder type hint r=adityamaru a=adityamaru

Fixes: #91728, #91725, #91726, #91727, #91736

Release note: None

Co-authored-by: adityamaru <[email protected]>
  • Loading branch information
craig[bot] and adityamaru committed Nov 14, 2022
2 parents 7f77f57 + b124e5d commit fed5abb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/multitenant_distsql.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func runMultiTenantDistSQL(
}

storConn := c.Conn(ctx, t.L(), 1)
_, err := storConn.Exec(`SELECT crdb_internal.create_tenant($1)`, tenantID)
_, err := storConn.Exec(`SELECT crdb_internal.create_tenant($1::INT)`, tenantID)
require.NoError(t, err)

instances := make([]*tenantNode, 0, numInstances)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/multitenant_upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ func runMultiTenantUpgrade(ctx context.Context, t test.Test, c cluster.Cluster,
// auto-update loop (at the time of writing 30s), plus some migrations may be
// genuinely long-running.
runner.SucceedsSoonDuration = 5 * time.Minute
runner.Exec(t, `SELECT crdb_internal.create_tenant($1)`, tenant11ID)
runner.Exec(t, `SELECT crdb_internal.create_tenant($1::INT)`, tenant11ID)

var initialVersion string
runner.QueryRow(t, "SHOW CLUSTER SETTING version").Scan(&initialVersion)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/smoketest_secure.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func multitenantSmokeTest(ctx context.Context, t test.Test, c cluster.Cluster) {
tenID := 11
ten := createTenantNode(ctx, t, c, c.Node(1), tenID, 2, 8011, 9011)
runner := sqlutils.MakeSQLRunner(c.Conn(ctx, t.L(), 1))
runner.Exec(t, `SELECT crdb_internal.create_tenant($1)`, tenID)
runner.Exec(t, `SELECT crdb_internal.create_tenant($1::INT)`, tenID)
ten.start(ctx, t, c, "./cockroach")

// this doesn't work yet, roachprod knows nothing about tenants
Expand Down

0 comments on commit fed5abb

Please sign in to comment.