Merge #120118

120118: roachprod: use logger for `printDetails` r=nameisbhaskar,renatolabs a=herkolategan A recent update to PrintDetails redirected output to `os.Stdout`, it should preferably write to the logger, in order for it to end up in the correct log when used with `roachtest`. This change points it to `logger.Stdout` instead. See: #119763 Epic: None Release Note: None Co-authored-by: Herko Lategan <[email protected]>
cockroachdb · Mar 11, 2024 · fcf0b5a · fcf0b5a
2 parents 8466258 + 1188249
commit fcf0b5a
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/pkg/roachprod/cloud/cluster_cloud.go b/pkg/roachprod/cloud/cluster_cloud.go
@@ -14,7 +14,6 @@ import (
 	"bytes"
 	"context"
 	"fmt"
-	"os"
 	"regexp"
 	"sort"
 	"text/tabwriter"
@@ -180,7 +179,7 @@ func (c *Cluster) PrintDetails(logger *logger.Logger) error {
 		logger.Printf("(no expiration)")
 	}
 	// Align columns left and separate with at least two spaces.
-	tw := tabwriter.NewWriter(os.Stdout, 0, 8, 2, ' ', 0)
+	tw := tabwriter.NewWriter(logger.Stdout, 0, 8, 2, ' ', 0)
 	logPrettifiedHeader(tw, printDetailsColumnHeaders)
 
 	for _, vm := range c.VMs {