-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
96287: sql: make schema between `crdb_internal.ranges` and `range_no_leases` consistent r=rafiss a=e-mbrown Resolves #93788 Release note (backward-incompatible change): The type of the `replicas`, `voting_replicas`, `non_voting_replicas` and `learner_replicas` in `crdb_internal.ranges` were overriden to `INT2VECTOR` causing incompatible indexing between `.ranges` and `.ranges_no_leases`. Now those column types are consistent between the two tables. 96389: issues: filter by exact title match when looking for existing issue r=herkolategan a=renatolabs This changes the logic used to find existing and related issues when posting test failures on GitHub. Previously, we would rely on the GitHub API to find issues with the a certain title; however, the GitHub API does not provide a way to filter by exact title match. Instead, issues that have a "similar" name are returned. As a consequence, when a test fails, we might comment on an existing issue for a different test, which is confusing and may mask failures. As a means of example, check issue #91594: failures for `schemachange/mixed-versions` and `schemachange/mixed-versions-compat` are both posted there for this reason. This commit does some further filtering on our end to ensure that an issue is only considered existing or related if the titles match exactly. Epic: none Release note: None Co-authored-by: e-mbrown <[email protected]> Co-authored-by: Renato Costa <[email protected]>
- Loading branch information
Showing
22 changed files
with
135 additions
and
104 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
pkg/cmd/internal/issues/testdata/post/failure-matching-issue.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.