Merge pull request #100495 from cockroachdb/blathers/backport-release…

…-23.1-100204

release-23.1: physicalplan: debugging for segfault in fakeSpanResolverIterator.Seek

pkg/sql/physicalplan/fake_span_resolver.go

@@ -167,11 +167,15 @@ func (fit *fakeSpanResolverIterator) Seek(
 	// Build ranges corresponding to the fake splits and assign them random
 	// replicas.
 	fit.ranges = make([]fakeRange, len(splits)-1)
+	// TODO(michae2): Condense this logic when #100051 is fixed.
+	nodes := fit.fsr.nodes
+	n := len(nodes)
 	for i := range fit.ranges {
+		j := fit.rng.Intn(n)
 		fit.ranges[i] = fakeRange{
 			startKey: splits[i],
 			endKey:   splits[i+1],
-			replica:  fit.fsr.nodes[fit.rng.Intn(len(fit.fsr.nodes))],
+			replica:  nodes[j],
 		}
 	}